From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24898 invoked by alias); 1 Apr 2011 15:15:27 -0000 Received: (qmail 24889 invoked by uid 22791); 1 Apr 2011 15:15:26 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Apr 2011 15:15:23 +0000 Received: (qmail 18109 invoked from network); 1 Apr 2011 15:15:22 -0000 Received: from unknown (HELO ?192.168.1.66?) (vries@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Apr 2011 15:15:22 -0000 Message-ID: <4D95EC07.60807@codesourcery.com> Date: Fri, 01 Apr 2011 15:15:00 -0000 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, ebotcazou@libertysurf.fr CC: Maxim Kuvyrkov , Bernd Schmidt Subject: Re: [PATCH, PR43920, 3/9] Cleanup. References: <4D94C603.7080505@codesourcery.com> <4D94C80C.10100@codesourcery.com> <4D95E5A7.7090201@codesourcery.com> In-Reply-To: <4D95E5A7.7090201@codesourcery.com> Content-Type: multipart/mixed; boundary="------------030105050105020006060600" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00047.txt.bz2 This is a multi-part message in MIME format. --------------030105050105020006060600 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 340 On 04/01/2011 05:01 PM, Jakub Jelinek wrote: > On Fri, Apr 01, 2011 at 04:56:10PM +0200, Tom de Vries wrote: >> Reposting, with ChangeLog. > > Similarly one of your patches had > * gcc/cfgcleanup.c (whatever): Whatever. > in the ChangeLog, should be just > * cfgcleanup.c (whatever): Whatever. > > Jakub Fixed ChangeLog. Thanks, - Tom --------------030105050105020006060600 Content-Type: text/x-patch; name="3_crossjump-cleanup-ml.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="3_crossjump-cleanup-ml.patch" Content-length: 1401 2011-04-01 Tom de Vries PR target/43920 * cfgcleanup.c (try_crossjump_bb): Remove 2 superfluous variables. diff -u gcc/cfgcleanup.c gcc/cfgcleanup.c --- gcc/cfgcleanup.c (working copy) +++ gcc/cfgcleanup.c (working copy) @@ -1961,7 +1961,6 @@ edge e, e2, fallthru; bool changed; unsigned max, ix, ix2; - basic_block ev, ev2; /* Nothing to do if there is not at least two incoming edges. */ if (EDGE_COUNT (bb->preds) < 2) @@ -2001,9 +2000,9 @@ fallthru = find_fallthru_edge (bb->preds); changed = false; - for (ix = 0, ev = bb; ix < EDGE_COUNT (ev->preds); ) + for (ix = 0; ix < EDGE_COUNT (bb->preds);) { - e = EDGE_PRED (ev, ix); + e = EDGE_PRED (bb, ix); ix++; /* As noted above, first try with the fallthru predecessor (or, a @@ -2021,7 +2020,6 @@ { changed = true; ix = 0; - ev = bb; continue; } } @@ -2045,10 +2043,9 @@ if (EDGE_SUCC (e->src, 0) != e) continue; - for (ix2 = 0, ev2 = bb; ix2 < EDGE_COUNT (ev2->preds); ) + for (ix2 = 0; ix2 < EDGE_COUNT (bb->preds); ix2++) { - e2 = EDGE_PRED (ev2, ix2); - ix2++; + e2 = EDGE_PRED (bb, ix2); if (e2 == e) continue; @@ -2071,7 +2068,6 @@ if (try_crossjump_to_edge (mode, e, e2)) { changed = true; - ev2 = bb; ix = 0; break; } --------------030105050105020006060600--