From: Nick Clifton <nickc@redhat.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Avoid global state in rx_handle_option
Date: Tue, 05 Apr 2011 11:22:00 -0000 [thread overview]
Message-ID: <4D9AFB75.4000208@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1104041645440.22197@digraph.polyomino.org.uk>
Hi Joseph,
> Tested building cc1 and xgcc for cross to rx-elf. Will commit to
> trunk in the absence of target maintainer objections.
>
> 2011-04-04 Joseph Myers<joseph@codesourcery.com>
>
> * config/rx/rx-opts.h: New.
> * config/rx/rx.c (rx_cpu_type): Remove.
> (rx_handle_option): Don't assert that global structures are in
> use. Access variables via opts pointer. Defer most handling of
> OPT_mint_register_. Use error_at.
> (rx_option_override): Handle deferred OPT_mint_register_ here.
> * config/rx/rx.h (enum rx_cpu_types): Move to rx-opts.h.
> * config/rx/rx.opt (config/rx/rx-opts.h: New HeaderInclude.
> (mcpu=): Use Enum and specifiy rx_cpu_type with Var.
> (rx_cpu_types): New Enum and EnumValue entries.
> (mint-register=): Use Defer and use Var accordingly.
No objections - please apply.
Cheers
Nick
next prev parent reply other threads:[~2011-04-05 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 16:48 Joseph S. Myers
2011-04-05 11:22 ` Nick Clifton [this message]
2011-04-07 21:48 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9AFB75.4000208@redhat.com \
--to=nickc@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).