From: Jeff Law <law@redhat.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: Steven Bosscher <stevenb.gcc@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] allocate combine.c:LOG_LINKS in an obstack
Date: Tue, 05 Apr 2011 16:13:00 -0000 [thread overview]
Message-ID: <4D9B3FA2.8020301@redhat.com> (raw)
In-Reply-To: <20110405145107.GH23480@codesourcery.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/05/11 08:51, Nathan Froyd wrote:
> On Tue, Apr 05, 2011 at 04:42:27PM +0200, Steven Bosscher wrote:
>> On Tue, Apr 5, 2011 at 3:59 PM, Nathan Froyd <froydnj@codesourcery.com> wrote:
>>> v2, now with obstacks!
>>
>> @findex LOG_LINKS
>> @item LOG_LINKS (@var{i})
>> A list (chain of @code{insn_list} expressions) giving information about
>> dependencies between instructions within a basic block. Neither a jump
>> nor a label may come between the related insns. These are only used by
>> the schedulers and by combine. This is a deprecated data structure.
>> Def-use and use-def chains are now preferred.
>
> So, being somewhat RTL-ignorant, is this patch going in the wrong
> direction? Should combine be using DF instead of constructing
> LOG_LINKS?
Ideally, we'd like to get rid of LOG_LINKS in favor of DF; however, I
don't think anyone has looked at what would be needed to make that
happen for combine.c or at what the memory & compile-time implications
might be for such a change.
I still think your patch is a step forward as it should reduce the load
on the garbage collector.
Jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJNmz+iAAoJEBRtltQi2kC7NQAH/0GKXSsi3aOoZ/TCYYa2FIpI
CfFPLaE9lXfXkFLNIXrVKcWC+NkqbLcFxEQFLusyfQAU4Aqcc0sxFEg69hSCJLPG
EWCUBhLqd3YbHpv3pLkykV0nOrd8wBqt24NCbLKaALsNkyvWUGx/hsM3O2lUUbAJ
YnUmuyAzx2e5fSQ1WZvfNVb2/GXe7/p0QEDCq/yWf1l/6Pide4EtjWy4NPCbx1C9
AI+P+sqHWwmd6wPzTZTLamOlFCg0QNXwhSJ5eYL0WBkLjuxE9M4EHPiVuyta1Y8c
xkCOspGxsq6UdNycM6aGprlHS8uX8O5s4i//lTx/xq5U4n5USKLe3SbLn3Qk9MM=
=h8QI
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-04-05 16:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 18:50 [PATCH] allocate combine.c:LOG_LINKS in an alloc_pool Nathan Froyd
2011-04-04 19:01 ` Steven Bosscher
2011-04-04 19:25 ` Nathan Froyd
2011-04-05 10:14 ` Richard Guenther
2011-04-05 14:00 ` [PATCH] allocate combine.c:LOG_LINKS in an obstack Nathan Froyd
2011-04-05 14:12 ` Richard Guenther
2011-04-05 14:43 ` Steven Bosscher
2011-04-05 14:51 ` Nathan Froyd
2011-04-05 15:07 ` Steven Bosscher
2011-04-05 16:13 ` Jeff Law [this message]
2011-04-05 18:23 ` Nathan Froyd
2011-04-05 18:28 ` Nathan Froyd
2011-04-05 19:29 ` H.J. Lu
2011-04-05 19:34 ` Nathan Froyd
2011-04-05 19:32 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B3FA2.8020301@redhat.com \
--to=law@redhat.com \
--cc=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).