From: Jeff Law <law@redhat.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list
Date: Tue, 05 Apr 2011 16:19:00 -0000 [thread overview]
Message-ID: <4D9B410E.4020709@redhat.com> (raw)
In-Reply-To: <20110405114440.GE23480@codesourcery.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/05/11 05:44, Nathan Froyd wrote:
> On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote:
>>> + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *,
>>> + last_basic_block);
>> nit; You're missing some whitespace here (after the VEC).
>
> This doesn't seem to be a hard-and-fast policy; all of the VEC code I
> remember writing or looking at recently has no spaces, and I checked the
> patch in on that basis. However, running grep indicates that we have a
> profusion of styles...
In a codebase as big as GCC, violations tends to slip in. If/when you
see stuff, we'd love to see patches which fix such problems.
jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJNm0EOAAoJEBRtltQi2kC72/gH+gO3bpEldTzuEblKU5XGyhRw
h92X43nPb7qZ/9SaH9RI+zc0XGRAclwqja7X360kFmC/b06AMTbakmsBkcIZDFUj
MhXnt5jsOtQGAA4UlA1rPaUTA8IPN+QzIfIe8puN8Yf/W5Q0nxxKzJPbujXLkK0o
+5dB8CXUOYQ0rAfkzleEUSdPi0iKm8wvg13HY83Q52EZvUQ3aWcxFPmXA0oIaz+v
FQVhjjzr4YvHd2MaomofWC/t246bLVB+L6ofZnjh0jkhAikC0/z+FLG8en0VfGhr
0it6/hRIchlZfRV6jh/dN6vLR+NwP8FHwG25O/G+jnPRbut3fw3BaaQr4n3dnTQ=
=vAx7
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-04-05 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 1:45 Nathan Froyd
2011-04-04 18:01 ` Jeff Law
2011-04-05 11:44 ` Nathan Froyd
2011-04-05 12:22 ` Richard Earnshaw
2011-04-05 12:30 ` Nathan Froyd
2011-04-05 12:55 ` Richard Earnshaw
2011-04-05 13:08 ` Jeff Law
2011-04-05 14:40 ` Richard Earnshaw
2011-04-05 18:10 ` Mike Stump
2011-04-05 19:18 ` Joseph S. Myers
2011-04-05 19:51 ` Nathan Froyd
2011-04-05 16:19 ` Jeff Law [this message]
2011-04-04 15:42 Steven Bosscher
2011-04-04 15:50 ` Nathan Froyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B410E.4020709@redhat.com \
--to=law@redhat.com \
--cc=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).