From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26372 invoked by alias); 5 Apr 2011 16:19:44 -0000 Received: (qmail 26362 invoked by uid 22791); 5 Apr 2011 16:19:42 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Apr 2011 16:19:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p35GJTSS022226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Apr 2011 12:19:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p35GJSdA023444; Tue, 5 Apr 2011 12:19:29 -0400 Received: from [10.3.113.84] (ovpn-113-84.phx2.redhat.com [10.3.113.84]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p35GJRf7008713; Tue, 5 Apr 2011 12:19:27 -0400 Message-ID: <4D9B410E.4020709@redhat.com> Date: Tue, 05 Apr 2011 16:19:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9 MIME-Version: 1.0 To: Nathan Froyd CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list References: <20110404014451.GA16239@nightcrawler> <4D9A0765.6020901@redhat.com> <20110405114440.GE23480@codesourcery.com> In-Reply-To: <20110405114440.GE23480@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00368.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/05/11 05:44, Nathan Froyd wrote: > On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote: >>> + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *, >>> + last_basic_block); >> nit; You're missing some whitespace here (after the VEC). > > This doesn't seem to be a hard-and-fast policy; all of the VEC code I > remember writing or looking at recently has no spaces, and I checked the > patch in on that basis. However, running grep indicates that we have a > profusion of styles... In a codebase as big as GCC, violations tends to slip in. If/when you see stuff, we'd love to see patches which fix such problems. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNm0EOAAoJEBRtltQi2kC72/gH+gO3bpEldTzuEblKU5XGyhRw h92X43nPb7qZ/9SaH9RI+zc0XGRAclwqja7X360kFmC/b06AMTbakmsBkcIZDFUj MhXnt5jsOtQGAA4UlA1rPaUTA8IPN+QzIfIe8puN8Yf/W5Q0nxxKzJPbujXLkK0o +5dB8CXUOYQ0rAfkzleEUSdPi0iKm8wvg13HY83Q52EZvUQ3aWcxFPmXA0oIaz+v FQVhjjzr4YvHd2MaomofWC/t246bLVB+L6ofZnjh0jkhAikC0/z+FLG8en0VfGhr 0it6/hRIchlZfRV6jh/dN6vLR+NwP8FHwG25O/G+jnPRbut3fw3BaaQr4n3dnTQ= =vAx7 -----END PGP SIGNATURE-----