From: Charles Wilson <cygwin@cwilson.fastmail.fm>
To: Arnaud Charlet <charlet@adacore.com>
Cc: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
Kai Tietz <ktietz70@googlemail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch ada]: Last fix for PR ada/47163 on windows native hosts
Date: Tue, 05 Apr 2011 16:45:00 -0000 [thread overview]
Message-ID: <4D9B4724.3090805@cwilson.fastmail.fm> (raw)
In-Reply-To: <20110405161148.GA71102@adacore.com>
On 4/5/2011 12:11 PM, Arnaud Charlet wrote:
>> As a side issue, it ALSO seems to me that Ada's Mafile.in is doing it
>> wrong, given Ralf's statements above:
>>
>> # Copy target independent sources
>> $(foreach f,$(ADA_INCLUDE_SRCS) $(LIBGNAT_SRCS), \
>> $(LN_S) $(fsrcpfx)ada/$(f) $(RTSDIR) ;) true
>>
>> But as this isn't shell code (some sort of Ada buildfile? I'm not
>> familiar with building Ada),
>
> This is standard GNU make code.
Sorry, I always have to check the manual for the more unusual features
of make...like everything in Functions:: node.
>> I'm not sure exactly how to "fix" it in the
>> event LN_S is ACTUALLY defined as "ln -s" or "ln" (which, recall, is NOT
>> the case on MSYS, which apparently uses cp -p).
>
> There is nothing broken here as far as I can tell, so nothing to "fix" here.
According to 'info Autoconf --index LN_S' as quoted by Ralf, it is not
*portable* to do
$(LN_S) a_file a_dir
because it behaves differently depending on whether LN_S is "ln -s",
"ln" (or, as in this case, "cp -p"). This:
$(LN_S) $(fsrcpfx)ada/$(f) $(RTSDIR)
fits that non-portable pattern -- assuming $(f) is always a file, and
$(RTSDIR) is actually a directory. Ralf recommends that, for
portability, it should be changed to something like
(cd $(RTSDIR) && $(LN_S) ??? $(basename $(f)) )
The only problem is how to express $(fsrcpfx)ada/$(f) as a relative path
from RTSDIR, or as an absolute path (maybe that's not a problem; I'm
unsure how fsrcpfx is defined).
--
Chuck
next prev parent reply other threads:[~2011-04-05 16:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 7:48 Kai Tietz
2011-04-05 8:03 ` Arnaud Charlet
2011-04-05 8:44 ` Kai Tietz
2011-04-05 8:52 ` Arnaud Charlet
2011-04-05 9:30 ` Kai Tietz
2011-04-05 9:33 ` Arnaud Charlet
2011-04-05 9:45 ` Kai Tietz
2011-04-05 9:59 ` Arnaud Charlet
2011-04-05 10:14 ` Kai Tietz
2011-04-05 10:19 ` Arnaud Charlet
2011-04-05 10:23 ` Kai Tietz
2011-04-05 12:51 ` Charles Wilson
2011-04-05 13:22 ` Arnaud Charlet
2011-04-05 14:15 ` Charles Wilson
2011-04-05 14:22 ` Ralf Wildenhues
2011-04-05 15:58 ` Charles Wilson
2011-04-05 16:11 ` Arnaud Charlet
2011-04-05 16:45 ` Charles Wilson [this message]
2011-04-05 16:50 ` Arnaud Charlet
2011-04-05 17:01 ` Charles Wilson
2011-04-06 4:44 ` Russ Allbery
2011-04-06 6:34 ` Arnaud Charlet
2011-04-06 6:42 ` Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B4724.3090805@cwilson.fastmail.fm \
--to=cygwin@cwilson.fastmail.fm \
--cc=Ralf.Wildenhues@gmx.de \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).