From: Jeff Law <law@redhat.com>
To: Tom de Vries <vries@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, ebotcazou@libertysurf.fr
Subject: Re: [PATCH, PR43920, 6/9] Cross-jumping - Use reg-notes.
Date: Wed, 06 Apr 2011 17:41:00 -0000 [thread overview]
Message-ID: <4D9CA5C0.7030900@redhat.com> (raw)
In-Reply-To: <4D95E724.4030600@codesourcery.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/01/11 08:54, Tom de Vries wrote:
> On 03/31/2011 11:16 PM, Tom de Vries wrote:
>> On 03/31/2011 08:52 PM, Jeff Law wrote:
>>
>>> On 03/31/11 12:42, Tom de Vries wrote:
>>>> Uses regnotes to analyze whether we can replace insn a by insn b, even
>>>> if we cannot replace insn b by insn a. Uses this info in crossjumping.
>>
>>> Shouldn't this be using single_set rather than digging through PATTERN,
>>> then verifying both are SETs, etc.?
>>>
>>> Otherwise don't you miss most of the benefit on architectures where most
>>> insns clobber the flags register in a PARALLEL with the SET?
>>
>> I see what you mean about missing these insns currently.
>>
>> I guess I will have to check that the non-SET part of the PARALLEL is
>> identical between the 2 insns.
>>
>> I'll update the patch to handle this case.
>
> changes compared to previous posting:
> - add ChangeLog.
> - use single_set
> - add equal_different_set_p and use it in can_replace_by
>
> Retested on x86_64.
> PR target/43920
> * cfgcleanup.c (equal_different_set_p, can_replace_by, merge_dir): New
> function.
> (old_insns_match_p): Change return type. Replace return false/true with
> return dir_none/dir_both. Use can_replace_by.
> (flow_find_cross_jump): Add dir_p parameter. Init replacement direction
> from dir_p. Register replacement direction in dir, last_dir and
> afterlast_dir. Handle new return type of old_insns_match_p using
> merge_dir. Return replacement direction in dir_p.
> (flow_find_head_matching_sequence, outgoing_edges_match): Handle new
> return type of old_insns_match_p.
> (try_crossjump_to_edge): Add argument to call to flow_find_cross_jump.
> * ifcvt.c ( cond_exec_process_if_block): Add argument to call to
> flow_find_cross_jump.
> * basic-block.h (enum replace_direction): New type.
> (flow_find_cross_jump): Add parameter to declaration.
OK
Jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJNnKW/AAoJEBRtltQi2kC7TC8IAJdB1hgkPmmC787EUBBycPCF
/ROYeWMZ62WyVqOD+eTVFXvv6v4s0XjPHQgS+zANBQPdvA3L8V2ugFYy66SWmQZj
1NSplCrBMRhS9Fu9M8uEWjvuVEUhqxOYLnPKXqeW/gD8UEHt2+gMLAGGFI4pxQRS
L+caqVMGvNvVZqMNAUTU7FLQfT1Zo50sBvbvm9w/GfjSVNC/dmkHRqf4Ta0oIDW/
Zm5oyX4FWzun8NbW+scaQlsxAiEA5xoxzXyGlLnj9UGCTiEeaYIsgg+SyYO8CeO0
o3FpsRfe+jMSK170cd7+mufPktjmCuAdiWQa2M7W6R04AOvdOV7DxNglHMHXljg=
=NrNE
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-04-06 17:41 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 18:27 [PATCH, PR43920] Improve code-size optimizations Tom de Vries
2011-03-31 18:29 ` [PATCH, PR43920, 1/9] ARM specific part Tom de Vries
2011-04-01 14:46 ` Tom de Vries
2011-04-01 15:19 ` Richard Earnshaw
2011-04-01 16:06 ` Tom de Vries
2011-04-02 7:47 ` Richard Guenther
2011-04-02 17:06 ` Tom de Vries
2011-04-03 7:38 ` Richard Guenther
2011-04-03 17:03 ` Tom de Vries
[not found] ` <BANLkTikEruAfGJ392FXtasLv6-yV2tYSRQ@mail.gmail.com>
2011-04-04 12:14 ` Richard Guenther
2011-04-04 12:23 ` Rainer Orth
2011-04-05 13:35 ` Tom de Vries
2011-05-03 18:19 ` Rainer Orth
2011-04-03 18:40 ` Mike Stump
2011-03-31 18:31 ` [PATCH, PR43920, 2/9] ARM specific part - test case Tom de Vries
2011-04-01 14:47 ` Tom de Vries
2011-04-01 15:17 ` Tom de Vries
2011-04-01 15:34 ` Richard Earnshaw
2011-04-01 16:10 ` Tom de Vries
2011-04-05 10:43 ` Tom de Vries
2011-04-05 12:20 ` Richard Earnshaw
2011-04-06 10:48 ` Ramana Radhakrishnan
2011-04-06 12:29 ` Tom de Vries
2011-03-31 18:35 ` [PATCH, PR43920, 3/9] Cleanup Tom de Vries
2011-03-31 18:43 ` Jeff Law
2011-04-01 14:48 ` Tom de Vries
2011-04-01 15:15 ` Tom de Vries
2011-04-04 18:26 ` Jeff Law
2011-03-31 18:35 ` [PATCH, PR43920, 4-9/9] Cross-jumping Tom de Vries
2011-03-31 18:36 ` [PATCH, PR43920, 4/9] Cross-jumping - Don't count use or clobber Tom de Vries
2011-03-31 18:40 ` Jeff Law
2011-03-31 19:09 ` Tom de Vries
2011-03-31 19:19 ` Jeff Law
2011-04-01 14:48 ` Tom de Vries
2011-04-04 19:11 ` Jeff Law
2011-03-31 18:42 ` [PATCH, PR43920, 5/9] Cross-jumping - Add missing use of return register Tom de Vries
2011-03-31 18:52 ` Jeff Law
2011-04-01 14:49 ` Tom de Vries
2011-04-04 19:11 ` Jeff Law
2011-03-31 18:44 ` [PATCH, PR43920, 6/9] Cross-jumping - Use reg-notes Tom de Vries
2011-03-31 18:56 ` Jeff Law
2011-03-31 21:25 ` Tom de Vries
2011-04-01 14:54 ` Tom de Vries
2011-04-04 16:14 ` Tom de Vries
2011-04-06 17:41 ` Jeff Law [this message]
2011-03-31 18:45 ` [PATCH, PR43920, 7/9] Cross-jumping - Extend search scope Tom de Vries
2011-03-31 18:58 ` Jeff Law
2011-04-05 11:44 ` Tom de Vries
2011-04-01 14:55 ` Tom de Vries
2011-04-05 21:45 ` Jeff Law
2011-03-31 18:46 ` [PATCH, PR43920, 8/9] Cross-jumping - Extend search scope - test case Tom de Vries
2011-03-31 19:00 ` Jeff Law
2011-04-01 14:56 ` Tom de Vries
2011-04-01 15:01 ` Jakub Jelinek
2011-04-01 15:18 ` Tom de Vries
2011-04-01 16:14 ` Tom de Vries
2011-04-05 21:46 ` Jeff Law
2011-03-31 18:56 ` [PATCH, PR43920, 9/9] Cross-jumping - Allow both directions Tom de Vries
2011-03-31 19:02 ` Jeff Law
2011-04-01 14:56 ` Tom de Vries
2011-04-05 21:46 ` Jeff Law
2011-03-31 21:16 ` [PATCH, PR43920] Improve code-size optimizations Eric Botcazou
2011-04-01 15:06 ` Tom de Vries
2011-04-01 16:06 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9CA5C0.7030900@redhat.com \
--to=law@redhat.com \
--cc=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=vries@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).