From: Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>
To: Ira Rosen <ira.rosen@linaro.org>
Cc: gcc-patches@gcc.gnu.org, Patch Tracking <patches@linaro.org>,
Ulrich Weigand <ulrich.weigand@linaro.org>
Subject: Re: [patch, ARM] Fix PR target/48252
Date: Thu, 07 Apr 2011 12:16:00 -0000 [thread overview]
Message-ID: <4D9DAB2C.6010306@linaro.org> (raw)
In-Reply-To: <BANLkTin25N7VntNxojyfWBNqbPBFV8_SmQ@mail.gmail.com>
On 07/04/11 08:42, Ira Rosen wrote:
> Hi,
>
> This patch makes both outputs of neon_vzip/vuzp/vtrn_internal
> explicitly dependent on both inputs, preventing incorrect
> optimization:
> for
> (a,b)<- vzip (c,d)
> and
> (e,f)<- vzip (g,d)
> CSE decides that b==f, since b and f depend only on d.
>
> Tested on arm-linux-gnueabi. OK for trunk?
This is OK for trunk.
> OK for 4.6 after testing?
I have no objections to this going into 4.5 and 4.6 since it corrects
the implementation of the neon intrinsics but please check with the
release managers.
cheers
Ramana
>
> Thanks,
> Ira
>
> ChangeLog:
>
> 2011-04-07 Ulrich Weigand<ulrich.weigand@linaro.org>
> Ira Rosen<ira.rosen@linaro.org>
>
> PR target/48252
> * config/arm/arm.c (neon_emit_pair_result_insn): Swap arguments
> to match neon_vzip/vuzp/vtrn_internal.
> * config/arm/neon.md (neon_vtrn<mode>_internal): Make both
> outputs explicitly dependent on both inputs.
> (neon_vzip<mode>_internal, neon_vuzp<mode>_internal): Likewise.
>
> testsuite/Changelog:
>
> PR target/48252
> * gcc.target/arm/pr48252.c: New test.
next prev parent reply other threads:[~2011-04-07 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 7:42 Ira Rosen
2011-04-07 12:16 ` Ramana Radhakrishnan [this message]
2011-05-01 7:30 ` Ira Rosen
2011-05-03 14:56 ` Ramana Radhakrishnan
2011-05-03 14:58 ` Richard Guenther
2011-05-06 9:57 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9DAB2C.6010306@linaro.org \
--to=ramana.radhakrishnan@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=ira.rosen@linaro.org \
--cc=patches@linaro.org \
--cc=ulrich.weigand@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).