From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17690 invoked by alias); 7 Apr 2011 19:47:58 -0000 Received: (qmail 17566 invoked by uid 22791); 7 Apr 2011 19:47:58 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from tatiana.utanet.at (HELO tatiana.utanet.at) (213.90.36.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Apr 2011 19:47:53 +0000 Received: from plenty.xoc.tele2net.at ([213.90.36.8]) by tatiana.utanet.at with esmtp (Exim 4.73) (envelope-from ) id 1Q7vBD-0001Gj-DK; Thu, 07 Apr 2011 21:47:47 +0200 Received: from d91-128-23-116.cust.tele2.at ([91.128.23.116] helo=[192.168.1.18]) by plenty.xoc.tele2net.at with esmtpa (Exim 4.73) (envelope-from ) id 1Q7vBD-0004AI-BG; Thu, 07 Apr 2011 21:47:47 +0200 Message-ID: <4D9E1596.9020707@domob.eu> Date: Thu, 07 Apr 2011 19:47:00 -0000 From: Daniel Kraft User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: Thomas Koenig CC: "fortran@gcc.gnu.org" , gcc-patches Subject: Re: [patch, fortran] More control over front end optimization References: <4D9E1168.50908@netcologne.de> In-Reply-To: <4D9E1168.50908@netcologne.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00577.txt.bz2 Hi, On 04/07/11 21:32, Thomas Koenig wrote: > following Joost's request, the attached patch gives the user more > control over front end optimization - it can now be selected or > deselected independent of normal optimization. I have also implemented a > warning for eliminated functions. > > Regression-tested. > > Once this is in, I will also mention the new options in the changes file. > > OK for trunk? Ok. Just my opinion (as non-native-speaker), though: +Wfunction-elimination +Fortran Warning +Warn about function call elimination "-Wfunction-elimination" sounds misleading to me -- just under the name, I would imagine you mean eliminating whole functions; as in "never used (anymore), remove". Since you mean elimination of *calls* to functions, could you use something like "-Wcall-elimination"? (Does not sound that much better... but if you have an idea, I would prefer a clearer option name. Otherwise just leave it.) +Warn if any calls to functions are eliminated by the +@option{-ffrontend-optimize} option. I also do not completely like "are eliminated by the -ffrontend-optimize option" -- since to me it is not *the option* which eliminates the calls; but the elimination is implied by the option... or something like that. But as before, if you have a good alternative I would love to see one, otherwise just leave it. The code looks good to me. Yours, Daniel -- http://www.pro-vegan.info/ -- Done: Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz To go: Hea-Mon-Pri