public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Janis Johnson <janisjo@codesourcery.com>
To: gcc-patches@gcc.gnu.org
Subject: [testsuite] fix to gcc.target/arm/sync-1.c
Date: Fri, 08 Apr 2011 15:08:00 -0000	[thread overview]
Message-ID: <4D9F24FB.7060901@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Test gcc.target/arm/sync-1.c specifies -march=armv7-a and fails
execution for multilibs whose hardware or simulator doesn't support that
architecture.  The test uses __sync_fetch_and_add, which GCC doesn't
support for all arm targets.  Using the -march option allows it to
compile if the multilib options don't conflict, but the test fails at
runtime, often with hangs, if the simulator used for testing doesn't
support atomic builtins.  This patch removes the -march option and
restricts the test to targets that support atomic builtins.

I don't yet have an FSF copyright assignment (it's currently in the
hands of the FSF) but this patch is small enough to not require one.  If
this is OK someone else will need to appy it.

[-- Attachment #2: gcc-20110407-2 --]
[-- Type: text/plain, Size: 542 bytes --]

2011-04-08  Janis Johnson  <janisjo@codesourcery.com>

	* gcc.target/arm/sync-1.c: Limit to sync_int_long, do not use
	-march option.

Index: gcc/testsuite/gcc.target/arm/sync-1.c
===================================================================
--- gcc/testsuite/gcc.target/arm/sync-1.c	(revision 320350)
+++ gcc/testsuite/gcc.target/arm/sync-1.c	(working copy)
@@ -1,5 +1,5 @@
-/* { dg-do run } */
-/* { dg-options "-O2 -march=armv7-a" } */
+/* { dg-do run { target sync_int_long } } */
+/* { dg-options "-O2" } */
 
 volatile int mem;
 

             reply	other threads:[~2011-04-08 15:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 15:08 Janis Johnson [this message]
2011-04-12 20:19 ` Ramana Radhakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9F24FB.7060901@codesourcery.com \
    --to=janisjo@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).