From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Henderson <rth@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix LTO bootstrap on i686-linux (problem with two Ldebug_info0 labels; PR bootstrap/48148)
Date: Fri, 08 Apr 2011 17:58:00 -0000 [thread overview]
Message-ID: <4D9F4CB6.2010004@redhat.com> (raw)
In-Reply-To: <20110405141939.GB17079@tyan-ft48-01.lab.bos.redhat.com>
On 04/05/2011 10:19 AM, Jakub Jelinek wrote:
> i686-linux LTO bootstrap currently fails, because in one partition
> we emit .Ldebug_info0 label twice. The problem is that
> resolve_addr for call_site support attempts to force_decl_die external
> function decls, and at least with LTO that in turn can attempt
> to create new type DIEs, in this case an enumeration with context_die
> being NULL. Unfortunately the code to add proper parents to limbo nodes
> is done right before resolve_addr (and should be done there, so that
> resolve_addr reaches all the needed DIEs).
>
> +/* Traverse the limbo die list, and add parent/child links. The only
> + dies without parents that should be here are concrete instances of
> + inline functions, and the comp_unit_die. We can ignore the comp_unit_die.
> + For concrete instances, we can get the parent die from the abstract
> + instance. */
Sounds like this comment needs to be updated if there can be types on
the list as well.
Jason
next prev parent reply other threads:[~2011-04-08 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 14:19 Jakub Jelinek
2011-04-05 21:06 ` Nathan Froyd
2011-04-05 21:11 ` Jakub Jelinek
2011-04-08 17:58 ` Jason Merrill [this message]
2011-04-08 19:11 ` Jakub Jelinek
2011-04-08 21:13 ` Richard Guenther
2011-04-08 21:41 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9F4CB6.2010004@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).