From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26554 invoked by alias); 8 Apr 2011 17:58:20 -0000 Received: (qmail 26543 invoked by uid 22791); 8 Apr 2011 17:58:19 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Apr 2011 17:58:15 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p38HwFjo024896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Apr 2011 13:58:15 -0400 Received: from [127.0.0.1] ([10.3.113.14]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p38HwE6M032334; Fri, 8 Apr 2011 13:58:14 -0400 Message-ID: <4D9F4CB6.2010004@redhat.com> Date: Fri, 08 Apr 2011 17:58:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: Jakub Jelinek CC: Richard Henderson , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix LTO bootstrap on i686-linux (problem with two Ldebug_info0 labels; PR bootstrap/48148) References: <20110405141939.GB17079@tyan-ft48-01.lab.bos.redhat.com> In-Reply-To: <20110405141939.GB17079@tyan-ft48-01.lab.bos.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00654.txt.bz2 On 04/05/2011 10:19 AM, Jakub Jelinek wrote: > i686-linux LTO bootstrap currently fails, because in one partition > we emit .Ldebug_info0 label twice. The problem is that > resolve_addr for call_site support attempts to force_decl_die external > function decls, and at least with LTO that in turn can attempt > to create new type DIEs, in this case an enumeration with context_die > being NULL. Unfortunately the code to add proper parents to limbo nodes > is done right before resolve_addr (and should be done there, so that > resolve_addr reaches all the needed DIEs). > > +/* Traverse the limbo die list, and add parent/child links. The only > + dies without parents that should be here are concrete instances of > + inline functions, and the comp_unit_die. We can ignore the comp_unit_die. > + For concrete instances, we can get the parent die from the abstract > + instance. */ Sounds like this comment needs to be updated if there can be types on the list as well. Jason