From: Jason Merrill <jason@redhat.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: C++/c-common PATCH to conversion from scoped enum to bool (part of 48450)
Date: Mon, 11 Apr 2011 21:54:00 -0000 [thread overview]
Message-ID: <4DA37889.6090008@redhat.com> (raw)
In-Reply-To: <4D9E2FA6.1010205@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On 04/07/2011 05:41 PM, Jason Merrill wrote:
> PR 48450 has to do with SFINAE bugs, but one of them turns out to be a
> different sort of bug: we were failing to convert from a non-constant
> value of scoped enum type to bool, because that conversion was doing a
> != 0, which requires an implicit conversion to int. So now we explicitly
> convert to the underlying integral type first, and prevent c-common from
> helpfully removing it again.
...except that if the underlying type is bool, this leads to infinite
recursion. So use build_nop instead of convert.
Tested x86_64-pc-linux-gnu, applying to trunk and 4.6.
[-- Attachment #2: 48534.patch --]
[-- Type: text/plain, Size: 1091 bytes --]
commit a2873eda4e9932624a2cd1ec77fb7554206b3574
Author: Jason Merrill <jason@redhat.com>
Date: Sun Apr 10 08:33:43 2011 -0400
PR c++/48534
* cvt.c (ocp_convert): Use build_nop to convert to underlying type
of scoped enum.
diff --git a/gcc/cp/cvt.c b/gcc/cp/cvt.c
index 6551de6..de981bc 100644
--- a/gcc/cp/cvt.c
+++ b/gcc/cp/cvt.c
@@ -731,7 +731,7 @@ ocp_convert (tree type, tree expr, int convtype, int flags)
/* We can't implicitly convert a scoped enum to bool, so convert
to the underlying type first. */
if (SCOPED_ENUM_P (intype) && (convtype & CONV_STATIC))
- e = convert (ENUM_UNDERLYING_TYPE (intype), e);
+ e = build_nop (ENUM_UNDERLYING_TYPE (intype), e);
return cp_truthvalue_conversion (e);
}
diff --git a/gcc/testsuite/g++.dg/cpp0x/enum10.C b/gcc/testsuite/g++.dg/cpp0x/enum10.C
new file mode 100644
index 0000000..55a1ab4
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/enum10.C
@@ -0,0 +1,9 @@
+// PR c++/48534
+// { dg-options -std=c++0x }
+
+enum class OpSE : bool;
+
+int main()
+{
+ return static_cast<bool>(OpSE());
+}
prev parent reply other threads:[~2011-04-11 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 21:42 Jason Merrill
2011-04-11 21:54 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA37889.6090008@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).