From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Eric Botcazou <ebotcazou@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Don't update_cfg_for_uncondjump for noop non-jump moves
Date: Tue, 12 Apr 2011 17:12:00 -0000 [thread overview]
Message-ID: <4DA487D9.70208@redhat.com> (raw)
In-Reply-To: <20110412170826.GG17079@tyan-ft48-01.lab.bos.redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/12/11 11:08, Jakub Jelinek wrote:
> On Tue, Apr 12, 2011 at 09:18:01AM +0200, Eric Botcazou wrote:
>>> The propagate_for_debug change alone could fix it, we should never
>>> fall through into next basic block. We are unforuntately not deleting
>>> just jumps (which ought to appear at the end of bbs), but also
>>> any other noop moves, which I think is unintentional, we have
>>> delete_noop_moves that should clean that up instead (see the second patch).
>>
>> Yes, I wondered several times about that. This clearly looks unintentional and
>> I agree that it is worth fixing on the mainline, adding gcc_assert (at_end); to
>> update_cfg_for_uncondjump in the process.
>
> Here is a patch, bootstrapped/regtested on x86_64-linux and i686-linux.
> Ok for trunk?
>
> 2011-04-12 Jakub Jelinek <jakub@redhat.com>
>
> * combine.c (update_cfg_for_uncondjump): Instead of testing at_end
> assert it is always true.
> (try_combine): Don't call update_cfg_for_uncondjump for noop non-jump
> moves.
Looks good to me, but please wait for Eric to chime in since you've been
discussing it with him already.
Thanks,
jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJNpIfYAAoJEBRtltQi2kC7yS4IAJZKDfF2fSkrEV1bWlz2p6Gm
P9w4mby36+tqY6AJBLXlaSo97DCGfhgJHuYNJdtC8a4ySz8EpVmEFdjGAfydU6oc
eIhaKfffm/dC8ciQfIQjBGh3mCe85LAOva9hY/3swyDJ2vFVZud/xY8QcC8RZIOk
b6qZ/whcbTDOWSbII81auzhI9fIfESx5Rk73nD2hUqoi8e5uCMPRlnwsLTDwiJfR
Cv8IJZ1kkIIc0i++wlZ9uuha+oRADcsj6awOKR9F07Qfa/ePU3xWw4e+auA6pfLL
eui0+Xp5BmkwOBc4vF7dl/lxugwRvKXdEB2OdiB96d7dwDBnC6B0a/7zqXZ9bsc=
=bwhq
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-04-12 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 10:50 [PATCH] Fix combiner ICEs after my recent patch (PR rtl-optimization/48549) Jakub Jelinek
2011-04-12 7:23 ` Eric Botcazou
2011-04-12 8:07 ` Jakub Jelinek
2011-04-12 8:35 ` Eric Botcazou
2011-04-12 10:55 ` Jakub Jelinek
2011-04-12 17:09 ` [PATCH] Don't update_cfg_for_uncondjump for noop non-jump moves Jakub Jelinek
2011-04-12 17:12 ` Jeff Law [this message]
2011-04-12 17:31 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA487D9.70208@redhat.com \
--to=law@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).