public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [testsuite] fix to gcc.target/arm/pr43698.c
@ 2011-04-08 15:07 Janis Johnson
  2011-04-08 23:37 ` Mike Stump
  0 siblings, 1 reply; 5+ messages in thread
From: Janis Johnson @ 2011-04-08 15:07 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails
execution for multilibs whose hardware or simulator doesn't support that
architecture.  The test doesn't depend on that option, and without it
will occasionally run for such a target anyway.  This patch removes the
option, letting it pass for all multilibs.

I don't yet have an FSF copyright assignment (it's currently in the
hands of the FSF) but this patch is small enough to not require one.  If
this is OK someone else will need to appy it.

[-- Attachment #2: gcc-20110407-1 --]
[-- Type: text/plain, Size: 492 bytes --]

2011-04-08  Janis Johnson  <janisjo@codesourcery.com>

	* gcc.target/arm/pr43698.c: Remove -march option.

Index: gcc/testsuite/gcc.target/arm/pr43698.c
===================================================================
--- gcc/testsuite/gcc.target/arm/pr43698.c	(revision 320350)
+++ gcc/testsuite/gcc.target/arm/pr43698.c	(working copy)
@@ -1,5 +1,5 @@
 /* { dg-do run } */
-/* { dg-options "-Os -march=armv7-a" } */
+/* { dg-options "-Os" } */
 #include <stdint.h>
 #include <stdlib.h>
 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [testsuite] fix to gcc.target/arm/pr43698.c
  2011-04-08 15:07 [testsuite] fix to gcc.target/arm/pr43698.c Janis Johnson
@ 2011-04-08 23:37 ` Mike Stump
  2011-04-12 19:16   ` Janis Johnson
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Stump @ 2011-04-08 23:37 UTC (permalink / raw)
  To: Janis Johnson; +Cc: gcc-patches

On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote:
> Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails
> execution for multilibs whose hardware or simulator doesn't support that
> architecture.

Ideally, I'd like target people to weigh in on target changes, ssa people to weigh in on ssa testcases and so on...  If they don't approve or reject it soon, I'll weigh in...  I don't see any reason not to approve it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [testsuite] fix to gcc.target/arm/pr43698.c
  2011-04-08 23:37 ` Mike Stump
@ 2011-04-12 19:16   ` Janis Johnson
  2011-04-12 20:16     ` Ramana Radhakrishnan
  2011-04-12 22:48     ` Ramana Radhakrishnan
  0 siblings, 2 replies; 5+ messages in thread
From: Janis Johnson @ 2011-04-12 19:16 UTC (permalink / raw)
  To: Mike Stump; +Cc: gcc-patches, ramana.radhakrishnan

On 04/08/2011 04:37 PM, Mike Stump wrote:
> On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote:
>> Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails
>> execution for multilibs whose hardware or simulator doesn't support that
>> architecture.
> 
> Ideally, I'd like target people to weigh in on target changes, ssa people to weigh in on ssa testcases and so on...  If they don't approve or reject it soon, I'll weigh in...  I don't see any reason not to approve it.

Ramana, is this change OK?  Please look also at a patch for gcc.target/arm/sync-1.c that I submitted right after this one.

Janis

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [testsuite] fix to gcc.target/arm/pr43698.c
  2011-04-12 19:16   ` Janis Johnson
@ 2011-04-12 20:16     ` Ramana Radhakrishnan
  2011-04-12 22:48     ` Ramana Radhakrishnan
  1 sibling, 0 replies; 5+ messages in thread
From: Ramana Radhakrishnan @ 2011-04-12 20:16 UTC (permalink / raw)
  To: Janis Johnson; +Cc: Mike Stump, gcc-patches, ramana.radhakrishnan

On 12 April 2011 20:16, Janis Johnson <janisjo@codesourcery.com> wrote:
> On 04/08/2011 04:37 PM, Mike Stump wrote:
>> On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote:
>>> Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails
>>> execution for multilibs whose hardware or simulator doesn't support that
>>> architecture.
>>
>> Ideally, I'd like target people to weigh in on target changes, ssa people to weigh in on ssa testcases and so on...  If they don't approve or reject it soon, I'll weigh in...  I don't see any reason not to approve it.
>
> Ramana, is this change OK?  Please look also at a patch for gcc.target/arm/sync-1.c that I submitted right after this one.

This is OK.

cheers
Ramana

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [testsuite] fix to gcc.target/arm/pr43698.c
  2011-04-12 19:16   ` Janis Johnson
  2011-04-12 20:16     ` Ramana Radhakrishnan
@ 2011-04-12 22:48     ` Ramana Radhakrishnan
  1 sibling, 0 replies; 5+ messages in thread
From: Ramana Radhakrishnan @ 2011-04-12 22:48 UTC (permalink / raw)
  To: Janis Johnson; +Cc: Mike Stump, gcc-patches, ramana.radhakrishnan

On 12/04/11 20:16, Janis Johnson wrote:
> On 04/08/2011 04:37 PM, Mike Stump wrote:
>> On Apr 8, 2011, at 8:07 AM, Janis Johnson wrote:
>>> Test gcc.target/arm/pr43698.c specifies -march=armv7-a and fails
>>> execution for multilibs whose hardware or simulator doesn't support that
>>> architecture.
>>
>> Ideally, I'd like target people to weigh in on target changes, ssa people to weigh in on ssa testcases and so on...  If they don't approve or reject it soon, I'll weigh in...  I don't see any reason not to approve it.
>
> Ramana, is this change OK?  Please look also at a patch for gcc.target/arm/sync-1.c that I submitted right after this one.
>


I have committed both these patches into trunk - Thanks .


Ramana
> Janis

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-04-12 22:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-08 15:07 [testsuite] fix to gcc.target/arm/pr43698.c Janis Johnson
2011-04-08 23:37 ` Mike Stump
2011-04-12 19:16   ` Janis Johnson
2011-04-12 20:16     ` Ramana Radhakrishnan
2011-04-12 22:48     ` Ramana Radhakrishnan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).