public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, Fortran] A tweak to fortran -> call graph interface
@ 2011-04-18 17:23 Martin Jambor
  2011-04-18 21:23 ` Tobias Burnus
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Jambor @ 2011-04-18 17:23 UTC (permalink / raw)
  To: GCC Patches; +Cc: Tobias Burnus

Hi,

this is a ping of a patch from the big cgraph_removal series that has
not got in yet
(http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00523.html).  I'd like
some Fortran reviewers to have a look, the fewer the calls to
cgraph_get_create_node the better.

Thanks a lot,

Martin

-------------------------------------------------

It seems to me that fortran can call cgraph_create_node directly
without checking for its existence first.

Bootstrapped and tested on x86_64-linux without any problems, tests on
i686 in progress.

Thanks,

Martin


2011-03-18  Martin Jambor  <mjambor@suse.cz>

	* trans-decl.c (gfc_generate_function_code): Call cgraph_create_node
	instead of cgraph_get_create_node.

Index: src/gcc/fortran/trans-decl.c
===================================================================
--- src.orig/gcc/fortran/trans-decl.c
+++ src/gcc/fortran/trans-decl.c
@@ -5046,7 +5046,7 @@ gfc_generate_function_code (gfc_namespac
   if (decl_function_context (fndecl))
     /* Register this function with cgraph just far enough to get it
        added to our parent's nested function list.  */
-    (void) cgraph_get_create_node (fndecl);
+    (void) cgraph_create_node (fndecl);
   else
     cgraph_finalize_function (fndecl, true);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, Fortran] A tweak to fortran -> call graph interface
  2011-04-18 17:23 [PATCH, Fortran] A tweak to fortran -> call graph interface Martin Jambor
@ 2011-04-18 21:23 ` Tobias Burnus
  0 siblings, 0 replies; 2+ messages in thread
From: Tobias Burnus @ 2011-04-18 21:23 UTC (permalink / raw)
  To: GCC Patches; +Cc: gfortran

Martin Jambor wrote:
> It seems to me that fortran can call cgraph_create_node directly
> without checking for its existence first.
>
> Bootstrapped and tested on x86_64-linux without any problems, tests on
> i686 in progress.

The patch is OK.

Tobias

> 2011-03-18  Martin Jambor<mjambor@suse.cz>
>
> 	* trans-decl.c (gfc_generate_function_code): Call cgraph_create_node
> 	instead of cgraph_get_create_node.
>
> Index: src/gcc/fortran/trans-decl.c
> ===================================================================
> --- src.orig/gcc/fortran/trans-decl.c
> +++ src/gcc/fortran/trans-decl.c
> @@ -5046,7 +5046,7 @@ gfc_generate_function_code (gfc_namespac
>     if (decl_function_context (fndecl))
>       /* Register this function with cgraph just far enough to get it
>          added to our parent's nested function list.  */
> -    (void) cgraph_get_create_node (fndecl);
> +    (void) cgraph_create_node (fndecl);
>     else
>       cgraph_finalize_function (fndecl, true);
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-18 20:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-18 17:23 [PATCH, Fortran] A tweak to fortran -> call graph interface Martin Jambor
2011-04-18 21:23 ` Tobias Burnus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).