From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23129 invoked by alias); 18 Apr 2011 20:55:39 -0000 Received: (qmail 23045 invoked by uid 22791); 18 Apr 2011 20:55:39 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx02.qsc.de (HELO mx02.qsc.de) (213.148.130.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Apr 2011 20:55:22 +0000 Received: from [192.168.178.22] (port-92-204-66-174.dynamic.qsc.de [92.204.66.174]) by mx02.qsc.de (Postfix) with ESMTP id 5E9401E4F2; Mon, 18 Apr 2011 22:55:21 +0200 (CEST) Message-ID: <4DACA538.5030105@net-b.de> Date: Mon, 18 Apr 2011 21:23:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7 MIME-Version: 1.0 To: GCC Patches CC: gfortran Subject: Re: [PATCH, Fortran] A tweak to fortran -> call graph interface References: <20110418170234.GD3555@virgil.arch.suse.de> In-Reply-To: <20110418170234.GD3555@virgil.arch.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01457.txt.bz2 Martin Jambor wrote: > It seems to me that fortran can call cgraph_create_node directly > without checking for its existence first. > > Bootstrapped and tested on x86_64-linux without any problems, tests on > i686 in progress. The patch is OK. Tobias > 2011-03-18 Martin Jambor > > * trans-decl.c (gfc_generate_function_code): Call cgraph_create_node > instead of cgraph_get_create_node. > > Index: src/gcc/fortran/trans-decl.c > =================================================================== > --- src.orig/gcc/fortran/trans-decl.c > +++ src/gcc/fortran/trans-decl.c > @@ -5046,7 +5046,7 @@ gfc_generate_function_code (gfc_namespac > if (decl_function_context (fndecl)) > /* Register this function with cgraph just far enough to get it > added to our parent's nested function list. */ > - (void) cgraph_get_create_node (fndecl); > + (void) cgraph_create_node (fndecl); > else > cgraph_finalize_function (fndecl, true); > >