From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-289926-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22663 invoked by alias); 19 Apr 2011 13:40:57 -0000
Received: (qmail 22655 invoked by uid 22791); 19 Apr 2011 13:40:56 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 13:40:42 +0000
Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7])	by smtp-out.google.com with ESMTP id p3JDeelX032683	for <gcc-patches@gcc.gnu.org>; Tue, 19 Apr 2011 06:40:41 -0700
Received: from ywg4 (ywg4.prod.google.com [10.192.7.4])	by hpaq7.eem.corp.google.com with ESMTP id p3JDe7VN021363	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT)	for <gcc-patches@gcc.gnu.org>; Tue, 19 Apr 2011 06:40:39 -0700
Received: by ywg4 with SMTP id 4so1472191ywg.10        for <gcc-patches@gcc.gnu.org>; Tue, 19 Apr 2011 06:40:39 -0700 (PDT)
Received: by 10.90.138.9 with SMTP id l9mr5224171agd.93.1303220438988;        Tue, 19 Apr 2011 06:40:38 -0700 (PDT)
Received: from [172.16.117.143] (dhcp-172-29-42-124.tor.corp.google.com [172.29.42.124])        by mx.google.com with ESMTPS id x32sm6434638ana.12.2011.04.19.06.40.37        (version=SSLv3 cipher=OTHER);        Tue, 19 Apr 2011 06:40:38 -0700 (PDT)
Message-ID: <4DAD90D4.1090401@google.com>
Date: Tue, 19 Apr 2011 14:05:00 -0000
From: Diego Novillo <dnovillo@google.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8
MIME-Version: 1.0
To: Richard Guenther <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org,        patches@linaro.org, Michael Matz <matz@suse.de>,        richard.sandiford@linaro.org
Subject: Re: RFA: Gimple calls to "internal" functions
References: <g4r59dgl6l.fsf@linaro.org> <g4lizdaqzf.fsf@linaro.org>	<BANLkTi=JbaqKrj6ZoM0zT3F_6jArC_j2+w@mail.gmail.com>	<g4wrirap1u.fsf@linaro.org>	<BANLkTikv==MM0AWAinFdPeJO+82JhEY2fw@mail.gmail.com>	<g4tydv8ytk.fsf@linaro.org>	<BANLkTik91acTh0pdQBgBmgiADebfVW=KEQ@mail.gmail.com> <g4ipua8jsx.fsf@linaro.org>
In-Reply-To: <g4ipua8jsx.fsf@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-04/txt/msg01530.txt.bz2

On 04/19/2011 09:14 AM, Richard Sandiford wrote:

> Tested on x86_64-linux-gnu and arm-linux-gnueabi.  OK to install?

OK with me.  Thanks for your patience.  Just a couple of minor nits below


> +  extern const int internal_fn_flags_array[];
> +  return internal_fn_flags_array[(int) fn];
> +}
> +
> +extern void expand_internal_call (gimple stmt);

s/stmt//

>   static inline tree
>   gimple_call_addr_fndecl (const_tree fn)
>   {
> -  if (TREE_CODE (fn) == ADDR_EXPR)
> +  if (fn&&  TREE_CODE (fn) == ADDR_EXPR)

Can't tell if thunderbird is being silly about spaces again or you are 
missing a space before '&&'.  I see it in a couple other places below, 
so I think it's just TB.


Diego.