From: Richard Henderson <rth@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch] Do not generate discriminator directive in strict mode
Date: Wed, 20 Apr 2011 21:10:00 -0000 [thread overview]
Message-ID: <4DAF4506.6050800@redhat.com> (raw)
In-Reply-To: <201104202109.26830.ebotcazou@adacore.com>
On 04/20/2011 12:09 PM, Eric Botcazou wrote:
>> How is this not redundant with the existing
>>
>> /* The discriminator column was added in dwarf4. Simplify the below
>> by simply removing it if we're not supposed to output it. */
>> if (dwarf_version < 4 && dwarf_strict)
>> discriminator = 0;
>>
>> check near the top of the function?
>
> Obviously I missed this recent change, sorry. So the question is: would the
> change be appropriate for the release branches, where we emit the directive
> unconditionally, i.e 4.5 and 4.6 branches, or would mine be safer for them?
Let's try to keep the branches more similar than not. It's just as safe, since
prior to mainline we ignore the discriminator when not emitting via gas directive.
r~
prev parent reply other threads:[~2011-04-20 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 14:10 Eric Botcazou
2011-04-20 18:22 ` Richard Henderson
2011-04-20 19:26 ` Eric Botcazou
2011-04-20 21:10 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAF4506.6050800@redhat.com \
--to=rth@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).