From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5675 invoked by alias); 26 Apr 2011 16:32:31 -0000 Received: (qmail 5440 invoked by uid 22791); 26 Apr 2011 16:32:30 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Apr 2011 16:32:16 +0000 Received: by wye20 with SMTP id 20so716937wye.20 for ; Tue, 26 Apr 2011 09:32:15 -0700 (PDT) Received: by 10.216.145.131 with SMTP id p3mr942927wej.82.1303835535135; Tue, 26 Apr 2011 09:32:15 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-184-88.ip51.fastwebnet.it [93.34.184.88]) by mx.google.com with ESMTPS id n2sm3102470wej.46.2011.04.26.09.32.13 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Apr 2011 09:32:13 -0700 (PDT) Message-ID: <4DB6F38B.6030907@gnu.org> Date: Tue, 26 Apr 2011 17:36:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9 MIME-Version: 1.0 To: Rainer Orth CC: David Miller , gcc-patches@gcc.gnu.org, ebotcazou@adacore.com Subject: Re: [build] Avoid ld -v error message with Sun ld on SPARC References: <20110412.155056.212685188.davem@davemloft.net> <20110413.105356.112601544.davem@davemloft.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg02055.txt.bz2 On 04/26/2011 05:25 PM, Rainer Orth wrote: > David, > >>> Thanks Rainer, if you cons up a patch to add the ".align" directive I'll ACK >>> that as well. >> >> here's the patch that I've been testing over the weekend. It caused no >> change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas >> and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now, and that >> configuration showed no testsuite regressions. >> >> Ok for mainline? > > it's been a week since I've submitted this patch. Or should I take it > as preapproved? > > Thanks. > Rainer > > >> 2011-04-15 David S. Miller >> Rainer Orth >> >> * configure.ac (gcc_cv_as_sparc_gotdata_op): Specify alignment. >> * configure: Regenerate. >> >> diff --git a/gcc/configure.ac b/gcc/configure.ac >> --- a/gcc/configure.ac >> +++ b/gcc/configure.ac >> @@ -3270,6 +3270,7 @@ case "$target" in >> gcc_cv_as_sparc_gotdata_op,, >> [-K PIC], >> [.text >> +.align 4 >> foo: >> nop >> bar: > I was waiting for David or Eric to approve it since I know nothing about this stuff. :) Paolo