From: Paolo Carlini <paolo.carlini@oracle.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [gomp3.1] Add support for parsing final and mergeable task clauses and taskyield directive
Date: Thu, 28 Apr 2011 16:04:00 -0000 [thread overview]
Message-ID: <4DB98BDD.5050209@oracle.com> (raw)
In-Reply-To: <20110428153449.GQ17079@tyan-ft48-01.lab.bos.redhat.com>
Hi,
minor nit:
> --- libgomp/testsuite/libgomp.c++/task-8.C (revision 0)
> +++ libgomp/testsuite/libgomp.c++/task-8.C (revision 0)
> @@ -0,0 +1,44 @@
> +// { dg-do run }
> +
> +#include<omp.h>
> +#include<cstdlib>
> + #pragma omp atomic read
> + e = err;
> + if (e)
> + abort ();
if you include <cstdlib> (vs <stdlib.h>), I think it would make much
more sense using std::abort: abort in the global namespace isn't portable.
Paolo.
prev parent reply other threads:[~2011-04-28 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 15:51 Jakub Jelinek
2011-04-28 16:04 ` Paolo Carlini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB98BDD.5050209@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).