From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20416 invoked by alias); 3 May 2011 08:16:02 -0000 Received: (qmail 20400 invoked by uid 22791); 3 May 2011 08:15:58 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 May 2011 08:15:40 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p438FVPN002088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 May 2011 04:15:31 -0400 Received: from [10.36.6.140] (vpn1-6-140.ams2.redhat.com [10.36.6.140]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p438FRSN008622; Tue, 3 May 2011 04:15:28 -0400 Message-ID: <4DBFB9E1.3040702@redhat.com> Date: Tue, 03 May 2011 08:16:00 -0000 From: Nick Clifton User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: "Joseph S. Myers" CC: gcc-patches@gcc.gnu.org, law@redhat.com, aoliva@redhat.com Subject: Re: Ping^4 Re: Target header etc. cleanup patch References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00139.txt.bz2 Hi Joseph, > I have seen no comments from the mn10300 maintainers. > I think > abbreviating const char * is actively bad. Cstar - defined for mn10300, > whose maintainers haven't commented Whilst I am not a maintainer for the MN10300, I am the author of that bit of code. I can say that I have no objections to removing the use of Cstar, it was just a syntactic shorthand, and not a very nice one at that. If you do not get a response from Jeff or Alex you might like to ping rth, as he has been actively reviewing my recent MN10300 patches. Cheers Nick