From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8833 invoked by alias); 9 May 2011 15:02:40 -0000 Received: (qmail 8824 invoked by uid 22791); 9 May 2011 15:02:39 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 May 2011 15:02:25 +0000 Received: (qmail 6819 invoked from network); 9 May 2011 15:02:24 -0000 Received: from unknown (HELO ?10.155.1.96?) (cltang@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 May 2011 15:02:24 -0000 Message-ID: <4DC801F9.1020104@codesourcery.com> Date: Mon, 09 May 2011 16:45:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: gcc-patches CC: Richard Earnshaw Subject: Ping Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part References: <4DB19D15.9020509@codesourcery.com> In-Reply-To: <4DB19D15.9020509@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00658.txt.bz2 Ping. On 04/22/2011 11:21 PM, Chung-Lin Tang wrote: > Hi Richard, this part's for you. > > The ARM backend changes needed are very little after the prior patches, > basically just a case in arm_canonicalize_comparison() to detect > (zero_extend:SI (subreg:QI (reg:SI ...) 0)), and swap it into (and:SI > (reg:SI) #255). > > Had we not tried the combine modifications, this testcase probably could > have also be solved by implementing another version of the corresponding > *andsi3_compare0/_scratch patterns, with ZERO_EXTEND in the body, and > "ands" in the output assembly. Maybe that's an acceptable solution too... > > About the (ab)use of CANONICALIZE_COMPARISON, if it really should be > another macro/hook, then this ARM patch will need updating, but the code > should be similar. > > Thanks, > Chung-Lin