public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: Jeff Law <law@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C++0x] contiguous bitfields race implementation
Date: Mon, 09 May 2011 18:05:00 -0000	[thread overview]
Message-ID: <4DC823B4.9070204@redhat.com> (raw)
In-Reply-To: <4DC82136.6030802@redhat.com>


>> struct
>> {
>>      unsigned int a : 4;
>>      unsigned char b;
>>      unsigned int c: 6;
>> } var;


> Well, the kernel guys would like to be able to be able to preserve the
> padding bits too.  It's a long long sad story that I won't repeat...
> And I don't think we should further complicate this stuff with the
> desire to not clobber padding bits :-)  Though be aware the request
> might come one day....

Woah, let me see if I got this right.  If we were to store in VAR.C 
above, the default for this memory model would be NOT to clobber the 
padding bits past <c>?  That definitely makes my implementation simpler, 
so I won't complain, but that's just weird.

>> Tested on x86-64 both with and without "--param
>> allow-store-data-races=0", and visually inspecting the assembly on
>> arm-linux and ia64-linux.
> Any way to add a test to the testsuite?

Arghhh... I was afraid you'd ask for one.  It was much easier with the 
test harness on cxx-memory-model.  I'll whip one up though...

Aldy

  reply	other threads:[~2011-05-09 17:26 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-09 17:12 Aldy Hernandez
2011-05-09 18:04 ` Jeff Law
2011-05-09 18:05   ` Aldy Hernandez [this message]
2011-05-09 19:19     ` Jeff Law
2011-05-09 20:11   ` Aldy Hernandez
2011-05-09 20:28     ` Jakub Jelinek
2011-05-10 11:42       ` Richard Guenther
2011-05-09 20:49     ` Jason Merrill
2011-05-13 22:35       ` Aldy Hernandez
2011-05-16 21:20         ` Aldy Hernandez
2011-05-19  7:17         ` Jason Merrill
2011-05-20  9:21           ` Aldy Hernandez
2011-05-26 18:05             ` Jason Merrill
2011-05-26 18:28               ` Aldy Hernandez
2011-05-26 19:07                 ` Jason Merrill
2011-05-26 20:19                   ` Aldy Hernandez
2011-05-27 20:41                     ` Jason Merrill
2011-07-18 13:10                       ` Aldy Hernandez
2011-07-22 19:16                         ` Jason Merrill
2011-07-25 17:41                           ` Aldy Hernandez
2011-07-26  5:28                             ` Jason Merrill
2011-07-26 18:37                               ` Aldy Hernandez
2011-07-26 17:54                                 ` Jason Merrill
2011-07-26 17:51                                   ` Aldy Hernandez
2011-07-26 18:05                                     ` Jason Merrill
2011-07-27 15:03                                       ` Richard Guenther
2011-07-27 15:12                                         ` Richard Guenther
2011-07-27 15:53                                           ` Richard Guenther
2011-07-28 13:00                                             ` Richard Guenther
2011-07-29  2:58                                               ` Jason Merrill
2011-07-29 12:02                                               ` Aldy Hernandez
2011-07-29 11:00                                                 ` Richard Guenther
2011-08-01 13:51                                                   ` Richard Guenther
2011-08-05 17:28                                               ` Aldy Hernandez
2011-08-09 10:52                                                 ` Richard Guenther
2011-08-09 20:53                                                   ` Aldy Hernandez
2011-08-10 13:34                                                     ` Richard Guenther
2011-08-15 19:26                                                       ` Aldy Hernandez
2011-08-27  0:05                                                         ` Aldy Hernandez
2011-08-29 12:54                                                           ` Richard Guenther
2011-08-30 16:07                                                             ` Aldy Hernandez
2011-08-31  8:38                                                               ` Richard Guenther
2011-08-31 13:56                                                                 ` Richard Guenther
2011-08-31 20:37                                                                   ` Aldy Hernandez
2011-09-01  6:58                                                                     ` Richard Guenther
2011-08-30 16:53                                                             ` Aldy Hernandez
2011-08-31  8:55                                                               ` Richard Guenther
2011-08-31 17:24                                                                 ` Aldy Hernandez
2011-08-30 21:33                                                             ` Aldy Hernandez
2011-08-31  8:55                                                               ` Richard Guenther
2011-08-31 20:37                                                                 ` Aldy Hernandez
2011-09-01  7:02                                                                   ` Richard Guenther
2011-09-01  7:05                                                                     ` Arnaud Charlet
2011-09-01 14:16                                                                     ` Aldy Hernandez
2011-09-02  8:48                                                                       ` Richard Guenther
2011-09-02 12:49                                                                         ` Aldy Hernandez
2011-09-02 13:05                                                                           ` Richard Guenther
2011-09-02 20:34                                                                         ` Jeff Law
2011-09-01 14:53                                                             ` Aldy Hernandez
2011-09-01 15:01                                                               ` Jason Merrill
2011-09-01 15:10                                                                 ` Aldy Hernandez
2011-09-01 15:20                                                                   ` Jason Merrill
2011-09-02  8:53                                                                     ` Richard Guenther
2011-09-02 14:10                                                                       ` Jason Merrill
2011-09-02 14:38                                                                         ` Richard Guenther
2011-09-07 18:12                                                                           ` Jason Merrill
2011-07-28 19:42                                             ` Aldy Hernandez
2011-07-27 18:22                                           ` Aldy Hernandez
2011-07-28  8:52                                             ` Richard Guenther
2011-07-29 12:05                                               ` Aldy Hernandez
2011-07-28 19:58                                                 ` Richard Guenther
2011-07-27 17:29                                         ` Aldy Hernandez
2011-07-27 17:57                                           ` Andrew MacLeod
2011-07-27 22:27                                             ` Joseph S. Myers
2011-07-28  8:58                                             ` Richard Guenther
2011-07-28 22:26                                         ` Aldy Hernandez
2011-07-26 20:05                               ` Aldy Hernandez
2011-07-27 18:24                             ` H.J. Lu
2011-07-27 20:39                               ` Aldy Hernandez
2011-07-27 20:54                                 ` Jakub Jelinek
2011-07-27 21:00                                   ` Aldy Hernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC823B4.9070204@redhat.com \
    --to=aldyh@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).