From: Tobias Burnus <burnus@net-b.de>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: fortran@gcc.gnu.org, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR48955 [4.6/4.7 Regression] Wrong result for array assignment due to missing temporary
Date: Thu, 12 May 2011 21:04:00 -0000 [thread overview]
Message-ID: <4DCC0D87.10500@net-b.de> (raw)
In-Reply-To: <BANLkTinVdeeaXsoBrki-YXnYMnuaNhwi_g@mail.gmail.com>
On 05/12/2011 05:46 PM, Paul Richard Thomas wrote:
> This patch fixes the problem in two steps:
> (i) It reverts r162289; and
> (ii) It adds the correct initialization for loop.reverse[] in
> gfc_trans_assignment_1. This was implemented incorrectly in the fix
> for PR24524 (in spite of the correct comment in dependency.c!) and
> removed at sometime, I do not know why.
> Bootstraps and regtests on x86_64/FC9. OK for trunk and 4.6?
Looks OK - unless Thomas has objections.
I would prefer if you could credit Kacper Kowalik for the example - he
reported it on IRC (and CCed himself to the PR after I reported it.) I
only relayed the example and did some minor analysis.
Tobias
PS: Regarding regressions, I think gfortran is doing fine - ignoring the
restricted pointer PR 45586. What are your next plans for gfortran? I
wouldn't mind if you could fix PR 47674 - it always pops up as only
testsuite failure when I regtest. Though, as the test case never worked,
I am not sure whether one can classify it as regression or not. (You may
need valgrind to reproduce the failure.)
> 2011-05-12 Paul Thomas<pault@gcc.gnu.org>
>
> PR fortran/48955
> * dependency.c (gfc_dep_resolver): Revert r162829 which changed
> the condition for setting this_dep to GFC_DEP_OVERLAP.
> * trans-expr.c (gfc_trans_assignment_1): Enable loop reversal.
>
> 2011-05-12 Paul Thomas<pault@gcc.gnu.org>
>
> PR fortran/48955
> * gfortran.dg/dependency_40.f90 : New test.
prev parent reply other threads:[~2011-05-12 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 19:05 Paul Richard Thomas
2011-05-12 21:04 ` Tobias Burnus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCC0D87.10500@net-b.de \
--to=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).