From: Jason Merrill <jason@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] C++0x, implement final on classes
Date: Fri, 13 May 2011 20:19:00 -0000 [thread overview]
Message-ID: <4DCD6E7C.4070302@redhat.com> (raw)
In-Reply-To: <87liyav7hf.wl%ville@ville-laptop>
On 05/13/2011 01:24 PM, Ville Voutilainen wrote:
> + error ("cannot derive from from final base %qT in derived type %qT",
Let's use %<final%> here.
> if (id)
> - cp_parser_check_for_invalid_template_id (parser, id,
> - type_start_token->location);
> + {
> + virt_specifiers = cp_parser_virt_specifier_seq_opt (parser);
> + cp_parser_check_for_invalid_template_id (parser, id,
> + type_start_token->location);
> + }
Why did you put this before the invalid template-id check, rather than
after?
Also, shouldn't we reject "override" on classes?
The test should include a class template marked final.
Jason
next prev parent reply other threads:[~2011-05-13 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 20:03 Ville Voutilainen
2011-05-13 20:19 ` Jason Merrill [this message]
2011-05-13 20:24 ` Ville Voutilainen
2011-05-13 20:48 ` Jason Merrill
2011-05-14 9:50 ` Ville Voutilainen
2011-05-14 14:35 ` Paolo Carlini
2011-05-14 18:15 ` Ville Voutilainen
2011-05-14 22:50 ` Jason Merrill
2011-05-14 22:52 ` Ville Voutilainen
2011-05-15 9:35 ` Jason Merrill
2011-05-15 10:25 ` Ville Voutilainen
2011-05-15 14:08 ` Jason Merrill
2011-05-15 15:43 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCD6E7C.4070302@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).