From: Pierre Vittet <piervit@pvittet.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] comment precising need to use free_dominance_info
Date: Tue, 17 May 2011 16:33:00 -0000 [thread overview]
Message-ID: <4DD281D7.6020409@pvittet.com> (raw)
In-Reply-To: <BANLkTikcV9YohVC2rgLcLdCBgb6DQd_Mxg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
So maybe this patch adding a comment on calculate_dominance_info is more
adapted.
ChangeLog:
2011-05-17 Pierre Vittet<piervit@pvittet.com>
* dominance.c (calculate_dominance_info): Add comment
precising when to free with free_dominance_info
contributor number: 634276
[-- Attachment #2: comment_calculate_dominance_info.diff --]
[-- Type: text/plain, Size: 768 bytes --]
Index: gcc/dominance.c
===================================================================
--- gcc/dominance.c (revision 173830)
+++ gcc/dominance.c (working copy)
@@ -628,8 +628,15 @@ compute_dom_fast_query (enum cdi_direction dir)
}
/* The main entry point into this module. DIR is set depending on whether
- we want to compute dominators or postdominators. */
+ we want to compute dominators or postdominators.
+ We try to keep dominance info alive as long as possible (to avoid
+ recomputing it often). It has to be freed with free_dominance_info when CFG
+ transformation makes it invalide.
+
+ post_dominance info is less often used, and should be freed after each use.
+*/
+
void
calculate_dominance_info (enum cdi_direction dir)
{
prev parent reply other threads:[~2011-05-17 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 6:55 piervit
2011-05-12 11:32 ` Richard Guenther
2011-05-17 16:33 ` Pierre Vittet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD281D7.6020409@pvittet.com \
--to=piervit@pvittet.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).