From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4017 invoked by alias); 19 May 2011 18:51:26 -0000 Received: (qmail 4004 invoked by uid 22791); 19 May 2011 18:51:25 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 18:51:10 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4JIp7pZ024543 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 May 2011 14:51:07 -0400 Received: from [127.0.0.1] (ovpn-113-120.phx2.redhat.com [10.3.113.120]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4JIp5dC013336; Thu, 19 May 2011 14:51:06 -0400 Message-ID: <4DD56699.6010607@redhat.com> Date: Thu, 19 May 2011 22:13:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Rainer Orth CC: Mike Stump , gcc-patches@gcc.gnu.org, David Edelsohn , Iain Sandoe , Richard Henderson Subject: Re: [build] Define HAVE_GAS_HIDDEN on Darwin References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01414.txt.bz2 On 05/19/2011 01:33 PM, Rainer Orth wrote: > The cleanest way to account for this seems to allow overriding > USE_LINKONCE_INDIRECT in target headers (darwin.h in this case). > > If Jason or Richard consider this appropriate, I'll modify the patch > accordingly and apply after retesting. Not really. The use in dwarf2asm seems no different from the use in i386.c, except that the latter has a special TARGET_MACHO case instead. As you say, dwarf2asm shouldn't be using .hidden directly, and that's the bug to fix. Jason