From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-292324-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4486 invoked by alias); 20 May 2011 16:51:34 -0000
Received: (qmail 4478 invoked by uid 22791); 20 May 2011 16:51:33 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,TW_TM,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from hub3.qnx.com (HELO hub3.qnx.com) (209.226.137.86)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 May 2011 16:51:19 +0000
Received: by hub3.qnx.com (Postfix, from userid 32767)	id 7657B6C51BC; Fri, 20 May 2011 12:50:55 -0400 (EDT)
Received: from orion.ott.qnx.com (orion.ott.qnx.com [10.42.3.40])	by hub3.qnx.com (Postfix) with ESMTP id 157336C51B5;	Fri, 20 May 2011 12:50:52 -0400 (EDT)
Received: from nebula.ott.qnx.com ([10.42.3.30]) by orion.ott.qnx.com with Microsoft SMTPSVC(6.0.3790.4675);	 Fri, 20 May 2011 12:51:13 -0400
Received: from [10.42.108.236] ([10.42.108.236]) by nebula.ott.qnx.com with Microsoft SMTPSVC(6.0.3790.4675);	 Fri, 20 May 2011 12:50:33 -0400
Message-ID: <4DD69BDA.3030701@qnx.com>
Date: Fri, 20 May 2011 19:22:00 -0000
From: Ryan Mansfield <rmansfield@qnx.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10
MIME-Version: 1.0
To: Richard Guenther <richard.guenther@gmail.com>
CC: gcc-patches@gcc.gnu.org
Subject: Re: Fix crash in vect_is_slp_reduction
References: <4DD67554.5050904@qnx.com> <BANLkTi=z6dpkz7ZmvJ+QZnv_hnW1W4+Vng@mail.gmail.com>
In-Reply-To: <BANLkTi=z6dpkz7ZmvJ+QZnv_hnW1W4+Vng@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-05/txt/msg01495.txt.bz2

On 11-05-20 10:17 AM, Richard Guenther wrote:
> On Fri, May 20, 2011 at 4:06 PM, Ryan Mansfield<rmansfield@qnx.com>  wrote:
>> There is a crash in vect_is_slp_reduction where use_stmt doesn't get
>> initialized in the FOR_EACH_IMM_USE_FAST loop.
>>
>> 1718          FOR_EACH_IMM_USE_FAST (use_p, imm_iter, lhs)
>> (gdb) call debug_tree(lhs)
>>   <ssa_name 0x7ffff6e3a5a0
>>     type<integer_type 0x7ffff7f8c7e0 int32_t sizes-gimplified public SI
>>         size<integer_cst 0x7ffff7ec47e0 constant 32>
>>         unit size<integer_cst 0x7ffff7ec4580 constant 4>
>>         align 32 symtab 0 alias set -1 canonical type 0x7ffff7ecb498
>> precision 32 min<integer_cst 0x7ffff7ec4780 -2147483648>  max<integer_cst
>> 0x7ffff7ec47a0 2147483647>  context<translation_unit_decl 0x7ffff7f98508
>> D.1314>
>>         pointer_to_this<pointer_type 0x7ffff7f9f930>>
>>     var<var_decl 0x7ffff6e1ce60 g_29_lsm.18>def_stmt g_29_lsm.18_137 = PHI
>> <g_29_lsm.18_87(15), D.2113_96(18)>
>>
>>     version 137>
>> (gdb) n
>> 1742          if (found)
>> (gdb)
>> 1746          if (gimple_code (use_stmt) == GIMPLE_PHI)
>> (gdb)
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> 0x0000000000980f22 in gimple_code (g=0x0) at ../../gcc/gimple.h:1098
>> 1098      return g->gsbase.code;
>>
>> Is the following sufficient?
>
> No, we shouldn't arrive with a NULL use_stmt here.

OK, thanks. I've filed PR49087 with a testcase.

Regards,

Ryan Mansfield