From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29065 invoked by alias); 23 May 2011 16:19:05 -0000 Received: (qmail 29054 invoked by uid 22791); 23 May 2011 16:19:03 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 16:18:43 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4NGIZDN003974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 May 2011 12:18:35 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4NGIZM7005840; Mon, 23 May 2011 12:18:35 -0400 Received: from [10.3.113.87] (ovpn-113-87.phx2.redhat.com [10.3.113.87]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4NGIXsW007527; Mon, 23 May 2011 12:18:34 -0400 Message-ID: <4DDA88D9.50307@redhat.com> Date: Mon, 23 May 2011 18:10:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Bernd Schmidt CC: GCC Patches Subject: Re: Remove obfuscation from the scheduler References: <4DD51D17.7000508@codesourcery.com> In-Reply-To: <4DD51D17.7000508@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01664.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/19/11 07:37, Bernd Schmidt wrote: > In the scheduler initialization code, we want to set up the h_i_d array. > So we call haifa_init_h_i_d, which has a table of function pointers > which it passes to sched_scan, which copies the function pointer table > pointer to a global variable and then calls functions like init_insn, > which checks the global variable whether one of the function pointers is > nonnull, and if not calls the function we actually want (init_h_i_d). > > Half of the arguments to sched_scan are never actually used. sel-sched > pretends to use the insns vector, but it actually passes in a global > variable that's always NULL. Another argument can be eliminated by > simply calling the necessary function(s) directly rather than going > through sched_scan. > > This patch removes most of the craziness. The forest of indirections is > gone, and sched_scan is moved (in a much reduced form) to sel-sched-ir.c > where the sel-sched maintainers can decide whether to eliminate it > altogether. > > Bootstrapped on i686-linux; regression tests running. Ok? Ok. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJN2ojZAAoJEBRtltQi2kC7hyYIAJ2IZ91/I4o0fqNljWPQy33o 7hgnV6Uy790QAlrfIVhQ/K4ceJRyo/0oHe/L/R87lemqronnUZiSSvA917G1mXEb LbjzjK0meGEl9pZZ3kwiCkJIWyUGqpEhDlRlVICqabpnFyu6fsOPJVrG9ZI8IIbz 4t+BwrawtB4+kAcsDZR2XvCEH4mte9an7nRlWUrHLvXuNWR8hxUS6T2Mx8dTtRH9 tC4BEodedbMGHeg8Sz3nAAftZ6SvGdS3K/Huwpl+VZ1uL2d2w+bTkgoLxobvNxtU hqrRgKlYGaeDuqgUyDmayPR9mNwM9GC7OXsJ8n12vmVe6p9FlFPV5yN/d8hCfpU= =aYbv -----END PGP SIGNATURE-----