From: Nathan Froyd <froydnj@codesourcery.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Basile Starynkevitch <basile@starynkevitch.net>,
Piervit <piervit@pvittet.com>,
dnovillo@google.com, gcc-patches@gcc.gnu.org
Subject: Re: external declaration of dominance debug functions
Date: Mon, 23 May 2011 23:06:00 -0000 [thread overview]
Message-ID: <4DDAC69A.9050804@codesourcery.com> (raw)
In-Reply-To: <BANLkTikrTMcW9iPTXao=V1QEEepub_MO7Q@mail.gmail.com>
On 05/23/2011 04:23 PM, Richard Guenther wrote:
>> So I don't buy Richie's argument. Otherwise, someone would propose a
>> patch to remove the hundreds of debug_ declarations in public header
>> files (i.e. those visible to plugins), and if he did, I hope such a
>> naughty patch won't be accepted.
>
> Such a patch would be pre-approved by me ;) Watch for not breaking
> -Wstrict-prototypes and move them to their respective .c file.
JFTR, the reason some of the prototypes are in headers are that they are
*gasp* needed by multiple files in GCC (debug_tree comes to mind). Removing
the ones that aren't so needed would be useful, but you can't delete them all
willy-nilly.
-Nathan
next prev parent reply other threads:[~2011-05-23 20:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 9:49 Piervit
2011-05-23 9:56 ` Basile Starynkevitch
2011-05-23 10:22 ` Richard Guenther
2011-05-23 10:53 ` Piervit
2011-05-23 20:55 ` Basile Starynkevitch
2011-05-23 22:52 ` Richard Guenther
2011-05-23 23:06 ` Nathan Froyd [this message]
2011-05-23 23:06 ` Richard Guenther
2011-05-24 10:42 ` Basile Starynkevitch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDAC69A.9050804@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=basile@starynkevitch.net \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=piervit@pvittet.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).