From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3568 invoked by alias); 23 May 2011 20:42:19 -0000 Received: (qmail 3557 invoked by uid 22791); 23 May 2011 20:42:19 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 20:42:05 +0000 Received: (qmail 14793 invoked from network); 23 May 2011 20:42:04 -0000 Received: from unknown (HELO ?192.168.1.78?) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 May 2011 20:42:04 -0000 Message-ID: <4DDAC69A.9050804@codesourcery.com> Date: Mon, 23 May 2011 23:06:00 -0000 From: Nathan Froyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0a2) Gecko/20110505 Thunderbird/3.3a4pre MIME-Version: 1.0 To: Richard Guenther CC: Basile Starynkevitch , Piervit , dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: Re: external declaration of dominance debug functions References: <20110523103355.71528d09@zenwalk.local> <20110523115632.5abb6956@zenwalk.local> <20110523201230.03ec2889.basile@starynkevitch.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01684.txt.bz2 On 05/23/2011 04:23 PM, Richard Guenther wrote: >> So I don't buy Richie's argument. Otherwise, someone would propose a >> patch to remove the hundreds of debug_ declarations in public header >> files (i.e. those visible to plugins), and if he did, I hope such a >> naughty patch won't be accepted. > > Such a patch would be pre-approved by me ;) Watch for not breaking > -Wstrict-prototypes and move them to their respective .c file. JFTR, the reason some of the prototypes are in headers are that they are *gasp* needed by multiple files in GCC (debug_tree comes to mind). Removing the ones that aren't so needed would be useful, but you can't delete them all willy-nilly. -Nathan