From: Nathan Froyd <froydnj@codesourcery.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH PING] unreviewed tree-slimming patches
Date: Thu, 26 May 2011 14:34:00 -0000 [thread overview]
Message-ID: <4DDE59A0.5080301@codesourcery.com> (raw)
In-Reply-To: <4DDE5812.9000709@redhat.com>
On 05/26/2011 09:39 AM, Jason Merrill wrote:
> On 05/25/2011 10:21 PM, Nathan Froyd wrote:
>> An alternative solution would be to initialize cur_stmt_list somewhere with an
>> actual 1-element VEC;
>
> Or just push NULL onto the stack and let append_to_statement_list_1 allocate
> the VEC?
Did you misspeak here? append_to_statement_1 shouldn't be caring about VECs.
Or do you mean pushing NULL_TREE someplace else, as in:
>> the check in add_stmt would then be unnecessary, as we'd
>> always be assured of having someplace in the stack to store it. I don't trust
>> myself to write a patch like that tonight; I'll twiddle with that tomorrow.
>
> Right, that's what I was thinking about. I think we should only need to do
> this once per function.
...here?
-Nathan
next prev parent reply other threads:[~2011-05-26 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 14:33 Nathan Froyd
2011-05-25 14:40 ` Jason Merrill
2011-05-26 8:47 ` Nathan Froyd
2011-05-26 14:00 ` Jason Merrill
2011-05-26 14:34 ` Nathan Froyd [this message]
2011-05-26 14:36 ` Jason Merrill
2011-05-27 4:54 ` Nathan Froyd
2011-05-27 8:14 ` Jason Merrill
2011-05-25 14:42 ` Richard Guenther
2011-05-25 17:44 ` Joseph S. Myers
2011-05-25 19:31 ` Tom Tromey
2011-05-25 19:36 ` Nathan Froyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE59A0.5080301@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).