Re: [ARM] TLS Descriptor support

[Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>]

Thanks for this and sorry about the length of time in reviewing this .

On 10/05/11 07:49, Nathan Sidwell wrote:
> This patch implements TLS descriptor support in GCC. TLS descriptors are
> described at
> http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt and blessed
> by ARM, who have reserved the relocation numbers.
>
> Binutils and GLIBC patches are already committed (there is an orthogonal
> glibc patch to do with make dependencies that I need to post though).
>
> This patch adds a --with-tls={arm|gnu} configuration option, to specify
> the default scheme. It can be overridden with a -mtls-dialect={arm|gnu}
> option (this is the name used by the x86 backend, which also has
> tlsdescriptor support). I have not added --with-tls support to the x86
> bits of config.gcc etc, but it would be simple to do so.

Could you consider adding a check in the configury to test if a binutils 
version of recent vintage is being used when --with-tls=gnu is in ?

Could you also use R0_REGNUM, R1_REGNUM instead of 0 and 1 in the 
"tlscall" pattern ?


>
> This patch has been tested for both default arm and default gnu tls
> schemes using the gcc and glibc testsuites for an arm-linux-gnueabi target.

Presumably for v7-a and v5te and with this as default ? On hardware ?


cheers
Ramana