From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12215 invoked by alias); 27 May 2011 00:47:39 -0000 Received: (qmail 12207 invoked by uid 22791); 27 May 2011 00:47:38 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 00:47:23 +0000 Received: by wye20 with SMTP id 20so1068677wye.20 for ; Thu, 26 May 2011 17:47:21 -0700 (PDT) Received: by 10.227.183.143 with SMTP id cg15mr1475648wbb.24.1306457241802; Thu, 26 May 2011 17:47:21 -0700 (PDT) Received: from [192.168.1.107] (66.37.187.81.in-addr.arpa [81.187.37.66]) by mx.google.com with ESMTPS id c17sm820615wbh.63.2011.05.26.17.47.20 (version=SSLv3 cipher=OTHER); Thu, 26 May 2011 17:47:20 -0700 (PDT) Message-ID: <4DDEF499.9090206@linaro.org> Date: Fri, 27 May 2011 04:43:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 MIME-Version: 1.0 To: Nathan Sidwell CC: GCC Patches Subject: Re: [ARM] TLS Descriptor support References: <4DC8DFF6.4000600@codesourcery.com> In-Reply-To: <4DC8DFF6.4000600@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg02119.txt.bz2 Thanks for this and sorry about the length of time in reviewing this . On 10/05/11 07:49, Nathan Sidwell wrote: > This patch implements TLS descriptor support in GCC. TLS descriptors are > described at > http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt and blessed > by ARM, who have reserved the relocation numbers. > > Binutils and GLIBC patches are already committed (there is an orthogonal > glibc patch to do with make dependencies that I need to post though). > > This patch adds a --with-tls={arm|gnu} configuration option, to specify > the default scheme. It can be overridden with a -mtls-dialect={arm|gnu} > option (this is the name used by the x86 backend, which also has > tlsdescriptor support). I have not added --with-tls support to the x86 > bits of config.gcc etc, but it would be simple to do so. Could you consider adding a check in the configury to test if a binutils version of recent vintage is being used when --with-tls=gnu is in ? Could you also use R0_REGNUM, R1_REGNUM instead of 0 and 1 in the "tlscall" pattern ? > > This patch has been tested for both default arm and default gnu tls > schemes using the gcc and glibc testsuites for an arm-linux-gnueabi target. Presumably for v7-a and v5te and with this as default ? On hardware ? cheers Ramana