From: Nathan Froyd <froydnj@codesourcery.com>
To: Lawrence Crowl <crowl@google.com>
Cc: reply@codereview.appspotmail.com, dnovillo@google.com,
gcc-patches@gcc.gnu.org
Subject: Re: [pph] More C++ Tree Nodes (issue4526083)
Date: Fri, 27 May 2011 06:11:00 -0000 [thread overview]
Message-ID: <4DDF0CC8.8000308@codesourcery.com> (raw)
In-Reply-To: <20110527022401.F1C91222645@jade.mtv.corp.google.com>
On 05/26/2011 10:24 PM, Lawrence Crowl wrote:
> Index: gcc/cp/cp-objcp-common.c
> ===================================================================
> --- gcc/cp/cp-objcp-common.c (revision 174301)
> +++ gcc/cp/cp-objcp-common.c (working copy)
> @@ -99,6 +99,8 @@ cp_tree_size (enum tree_code code)
>
> case TEMPLATE_INFO: return sizeof (struct tree_template_info);
>
> + case TREE_BINFO: return sizeof (struct tree_binfo);
> +
> default:
> gcc_unreachable ();
> }
This does not look right; TREE_BINFO is a variable-sized structure (and is not
C++-specific in any event). Maybe you should be using tree_size instead of
tree_code_size someplace?
-Nathan
next prev parent reply other threads:[~2011-05-27 2:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 4:57 Lawrence Crowl
2011-05-27 6:11 ` Nathan Froyd [this message]
2011-05-27 19:09 ` Lawrence Crowl
2011-05-27 14:12 dnovillo
2011-05-27 19:18 ` Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDF0CC8.8000308@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=crowl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).