From: Paolo Carlini <paolo.carlini@oracle.com>
To: Jason Merrill <jason@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] PR 42056
Date: Fri, 27 May 2011 12:04:00 -0000 [thread overview]
Message-ID: <4DDF664A.9060509@oracle.com> (raw)
In-Reply-To: <4DDF2095.3020300@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
Hi,
> On 05/26/2011 02:30 PM, Paolo Carlini wrote:
>> We want to do that only when processing a template, because otherwise we
>> get a duplicate diagnostic, see, eg, auto9.C
> Hmm, where's the error coming from in the non-template case? From
> cp_build_c_cast? In that case always giving the error in
> build_functional_cast and then returning error_mark_node should avoid
> duplication.
I should have told you. The error is produced via
complete_type_or_maybe_complain called from line 1650 of
build_functional_cast itself, by cxx_incomplete_type_diagnostic.
>> error_mark_node unconditionally, means a better diagnostic, without
>> redundant "array bound is not an integer constant before...".
> I'd rather deal with that by suppressing that error if we already have
> error_mark_node.
complete_type_or_maybe_complain, when type is an error_mark_node
understands that an error has been produced already and simply returns
NULL_TREE. Thus, something like the below works. Is it closer to what
you had in mind?
Paolo.
/////////////////
[-- Attachment #2: CL_42056_2 --]
[-- Type: text/plain, Size: 355 bytes --]
/cp
2011-05-27 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/42056
* typeck2.c (build_functional_cast): Complain early for invalid uses
of 'auto' and set type to error_mark_node.
/testsuite
2011-05-27 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/42056
* testsuite/g++.dg/cpp0x/auto25.C: New.
* testsuite/g++.dg/cpp0x/auto26.C: Likewise.
[-- Attachment #3: patch_42056_2 --]
[-- Type: text/plain, Size: 1177 bytes --]
Index: testsuite/g++.dg/cpp0x/auto25.C
===================================================================
--- testsuite/g++.dg/cpp0x/auto25.C (revision 0)
+++ testsuite/g++.dg/cpp0x/auto25.C (revision 0)
@@ -0,0 +1,7 @@
+// PR c++/42056
+// { dg-options -std=c++0x }
+
+template<int> struct A
+{
+ int a[auto(1)]; // { dg-error "invalid use of" }
+};
Index: testsuite/g++.dg/cpp0x/auto26.C
===================================================================
--- testsuite/g++.dg/cpp0x/auto26.C (revision 0)
+++ testsuite/g++.dg/cpp0x/auto26.C (revision 0)
@@ -0,0 +1,7 @@
+// PR c++/42056
+// { dg-options -std=c++0x }
+
+template<int> void foo()
+{
+ int a[auto(1)]; // { dg-error "invalid use of" }
+}
Index: cp/typeck2.c
===================================================================
--- cp/typeck2.c (revision 174321)
+++ cp/typeck2.c (working copy)
@@ -1599,6 +1599,13 @@ build_functional_cast (tree exp, tree parms, tsubs
return error_mark_node;
}
+ if (type_uses_auto (type))
+ {
+ if (complain & tf_error)
+ error ("invalid use of %<auto%>");
+ type = error_mark_node;
+ }
+
if (processing_template_decl)
{
tree t;
next prev parent reply other threads:[~2011-05-27 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 19:38 Paolo Carlini
2011-05-26 20:23 ` Paolo Carlini
2011-05-27 7:20 ` Jason Merrill
2011-05-27 12:04 ` Paolo Carlini [this message]
2011-05-27 14:26 ` Jason Merrill
2011-05-27 16:36 ` Paolo Carlini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDF664A.9060509@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).