From: Richard Henderson <rth@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Uros Bizjak <ubizjak@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: Use i386/crtfastmath.c on Solaris 2/x86
Date: Wed, 01 Jun 2011 17:24:00 -0000 [thread overview]
Message-ID: <4DE675B4.5040801@redhat.com> (raw)
In-Reply-To: <yddlixld2qh.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On 06/01/2011 07:51 AM, Rainer Orth wrote:
> + /* Set PC to the instruction after the faulting one to skip over it,
> + otherwise we enter an infinite loop. 4 is the size of the stmxcsr
> + instruction. */
...
> + /* We need a single SSE instruction here so the handler can safely skip
> + over it. */
> + __asm__ volatile ("movss %xmm2,%xmm1");
The comment referencing stmxcsr doesn't match the movss code.
It's still a 4 byte opcode, so the code still works.
I do wonder if using "movaps %xmm0,%xmm0" might be cleaner,
to avoid clobbering a register, even if that register is
surely dead anyway. That's a 3 byte opcode though, so the
handler would need updating.
r~
next prev parent reply other threads:[~2011-06-01 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 14:01 Rainer Orth
2011-05-31 14:23 ` Uros Bizjak
2011-06-01 14:51 ` Rainer Orth
2011-06-01 17:24 ` Richard Henderson [this message]
2011-06-01 17:29 ` Rainer Orth
2011-06-01 18:06 ` Richard Henderson
2011-06-03 17:39 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE675B4.5040801@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).