From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22361 invoked by alias); 1 Jun 2011 17:24:25 -0000 Received: (qmail 22352 invoked by uid 22791); 1 Jun 2011 17:24:23 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_MX,TW_TM,TW_XC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Jun 2011 17:24:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51HO4I0003750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 1 Jun 2011 13:24:04 -0400 Received: from anchor.twiddle.net (vpn-236-219.phx2.redhat.com [10.3.236.219]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p51HO4No029154; Wed, 1 Jun 2011 13:24:04 -0400 Message-ID: <4DE675B4.5040801@redhat.com> Date: Wed, 01 Jun 2011 17:24:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: Rainer Orth CC: Uros Bizjak , gcc-patches@gcc.gnu.org Subject: Re: Use i386/crtfastmath.c on Solaris 2/x86 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00069.txt.bz2 On 06/01/2011 07:51 AM, Rainer Orth wrote: > + /* Set PC to the instruction after the faulting one to skip over it, > + otherwise we enter an infinite loop. 4 is the size of the stmxcsr > + instruction. */ ... > + /* We need a single SSE instruction here so the handler can safely skip > + over it. */ > + __asm__ volatile ("movss %xmm2,%xmm1"); The comment referencing stmxcsr doesn't match the movss code. It's still a 4 byte opcode, so the code still works. I do wonder if using "movaps %xmm0,%xmm0" might be cleaner, to avoid clobbering a register, even if that register is surely dead anyway. That's a 3 byte opcode though, so the handler would need updating. r~