From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31230 invoked by alias); 2 Jun 2011 04:59:36 -0000 Received: (qmail 31222 invoked by uid 22791); 2 Jun 2011 04:59:35 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jun 2011 04:59:16 +0000 Received: (qmail 9649 invoked from network); 2 Jun 2011 04:59:15 -0000 Received: from unknown (HELO ?192.168.1.16?) (cltang@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Jun 2011 04:59:15 -0000 Message-ID: <4DE718A4.4030204@codesourcery.com> Date: Thu, 02 Jun 2011 04:59:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: gcc-patches CC: Richard Earnshaw , Ramana Radhakrishnan Subject: Ping Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part References: <4DB19D15.9020509@codesourcery.com> <4DC801F9.1020104@codesourcery.com> In-Reply-To: <4DC801F9.1020104@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00121.txt.bz2 Ping. On 2011/5/9 11:02 PM, Chung-Lin Tang wrote: > Ping. > > On 04/22/2011 11:21 PM, Chung-Lin Tang wrote: >> Hi Richard, this part's for you. >> >> The ARM backend changes needed are very little after the prior patches, >> basically just a case in arm_canonicalize_comparison() to detect >> (zero_extend:SI (subreg:QI (reg:SI ...) 0)), and swap it into (and:SI >> (reg:SI) #255). >> >> Had we not tried the combine modifications, this testcase probably could >> have also be solved by implementing another version of the corresponding >> *andsi3_compare0/_scratch patterns, with ZERO_EXTEND in the body, and >> "ands" in the output assembly. Maybe that's an acceptable solution too... >> >> About the (ab)use of CANONICALIZE_COMPARISON, if it really should be >> another macro/hook, then this ARM patch will need updating, but the code >> should be similar. >> >> Thanks, >> Chung-Lin >