From: Bruce Korb <bkorb@gnu.org>
To: Douglas B Rupp <rupp@gnat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fixincludes/Makefile for Interix
Date: Sun, 05 Jun 2011 17:19:00 -0000 [thread overview]
Message-ID: <4DEBBA7A.30906@gnu.org> (raw)
In-Reply-To: <4DEA98E4.3070402@gnat.com>
On 06/04/11 13:43, Douglas B Rupp wrote:
> Here's my proposed patch, along the lines you suggested.
Hi Doug,
Excellent. Just a couple nits:
It is more normal and easier to read when you quote the entire shell
script fragment, as below (removing unnecessary "eval", too):
> diff -rupN gcc.orig/fixincludes/configure.ac gcc/fixincludes/configure.ac
> --- gcc.orig/fixincludes/configure.ac 2011-04-06 17:01:09.000000000 -0700
> +++ gcc/fixincludes/configure.ac 2011-06-04 13:18:23.000000000 -0700
> @@ -23,6 +23,20 @@ ACX_PROG_CC_WARNINGS_ARE_ERRORS([manual]
> # Determine the noncanonical target name, for directory use.
> ACX_NONCANONICAL_TARGET
>
> +[host_makefile_frag=/dev/null
> +if test -d ${srcdir}/../config ; then
> +case "${host}" in
> + *-interix[3-9]*)
> + host_makefile_frag="${srcdir}/../config/mh-interix"
> + ;;
> +esac
> +fi]
> +AC_SUBST_FILE(host_makefile_frag)
> +
> # Specify the local prefix
> local_prefix=
> AC_ARG_WITH(local-prefix,
next prev parent reply other threads:[~2011-06-05 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 17:01 How to patch fixincludes/Makefile for Interix? Douglas B Rupp
2011-06-03 17:17 ` Bruce Korb
2011-06-04 20:43 ` [PATCH] fixincludes/Makefile for Interix Douglas B Rupp
2011-06-05 17:19 ` Bruce Korb [this message]
2011-06-07 4:37 ` [PATCH] fixincludes/Makefile for Interix Rev 2 Douglas B Rupp
2011-06-07 7:20 ` Paolo Bonzini
2011-06-08 6:29 ` [PATCH] fixincludes/Makefile for Interix Rev 3 Douglas B Rupp
2011-06-08 7:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEBBA7A.30906@gnu.org \
--to=bkorb@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rupp@gnat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).