From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6819 invoked by alias); 5 Jun 2011 17:19:09 -0000 Received: (qmail 6810 invoked by uid 22791); 5 Jun 2011 17:19:08 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-pw0-f47.google.com (HELO mail-pw0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Jun 2011 17:18:53 +0000 Received: by pwj9 with SMTP id 9so1810746pwj.20 for ; Sun, 05 Jun 2011 10:18:52 -0700 (PDT) Received: by 10.142.3.13 with SMTP id 13mr554943wfc.337.1307294332559; Sun, 05 Jun 2011 10:18:52 -0700 (PDT) Received: from [10.0.0.2] (adsl-75-2-131-205.dsl.pltn13.sbcglobal.net [75.2.131.205]) by mx.google.com with ESMTPS id k4sm3061495pbl.11.2011.06.05.10.18.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Jun 2011 10:18:51 -0700 (PDT) Message-ID: <4DEBBA7A.30906@gnu.org> Date: Sun, 05 Jun 2011 17:19:00 -0000 From: Bruce Korb Reply-To: bkorb@gnu.org User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Douglas B Rupp CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fixincludes/Makefile for Interix References: <4DE9132E.3080205@gnat.com> <4DEA98E4.3070402@gnat.com> In-Reply-To: <4DEA98E4.3070402@gnat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00329.txt.bz2 On 06/04/11 13:43, Douglas B Rupp wrote: > Here's my proposed patch, along the lines you suggested. Hi Doug, Excellent. Just a couple nits: It is more normal and easier to read when you quote the entire shell script fragment, as below (removing unnecessary "eval", too): > diff -rupN gcc.orig/fixincludes/configure.ac gcc/fixincludes/configure.ac > --- gcc.orig/fixincludes/configure.ac 2011-04-06 17:01:09.000000000 -0700 > +++ gcc/fixincludes/configure.ac 2011-06-04 13:18:23.000000000 -0700 > @@ -23,6 +23,20 @@ ACX_PROG_CC_WARNINGS_ARE_ERRORS([manual] > # Determine the noncanonical target name, for directory use. > ACX_NONCANONICAL_TARGET > > +[host_makefile_frag=/dev/null > +if test -d ${srcdir}/../config ; then > +case "${host}" in > + *-interix[3-9]*) > + host_makefile_frag="${srcdir}/../config/mh-interix" > + ;; > +esac > +fi] > +AC_SUBST_FILE(host_makefile_frag) > + > # Specify the local prefix > local_prefix= > AC_ARG_WITH(local-prefix,