From: Paolo Bonzini <bonzini@gnu.org>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gcc-patches@gcc.gnu.org,
"Joseph S. Myers" <joseph@codesourcery.com>,
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
Mike Stump <mikestump@comcast.net>,
"Loren J. Rittle" <ljrittle@acm.org>,
Kai Tietz <ktietz@redhat.com>,
Dave Korn <dave.korn.cygwin@gmail.com>,
Jason Thorpe <thorpej@netbsd.org>,
Krister Walfridsson <krister.walfridsson@gmail.com>,
Uros Bizjak <ubizjak@gmail.com>,
Richard Henderson <rth@redhat.com>,
Eric Botcazou <ebotcazou@adacore.com>
Subject: Re: [build] Move ENABLE_EXECUTE_STACK to toplevel libgcc
Date: Mon, 06 Jun 2011 09:23:00 -0000 [thread overview]
Message-ID: <4DEC9C6A.3050106@gnu.org> (raw)
In-Reply-To: <ydd1uz7qpx4.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On 06/06/2011 11:17 AM, Rainer Orth wrote:
> * Instead of __FreeBSD__, one could use HAVE_SYSCTLBYNAME instead, but
> that would need a new libgcc config.h header. In addition, we might
> have to check for kern.stackprot to make sure the code really works.
>
> * Similarly, instead of testing __sun__&& __svr4__, one could check
> _SC_STACK_PROT.
>
> * Last, rather than checking __NetBSD__, one could go for HAVE___SYSCTL.
>
> * __sysctl is currently declared manully. AFAICS there's no header for
> that. At least the FreeBSD libc declares it itself in two places:
> lib/libc/sys/stack_protector.c and lib/libc/gen/sysctl.c.
>
> Given that this is closely tied to the various platforms, it seems
> appropriate to continue to use the OS defines.
Agreed, it would be a worse can of worms when bootstrapping a target
(i.e. no target headers are available).
Parts I can approve are good. Thanks!
Paolo
next prev parent reply other threads:[~2011-06-06 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 18:09 Rainer Orth
2011-05-30 20:09 ` Kai Tietz
2011-05-31 9:45 ` Paolo Bonzini
2011-05-31 16:40 ` Rainer Orth
2011-05-31 16:57 ` Paolo Bonzini
2011-06-03 15:45 ` Rainer Orth
2011-06-03 16:01 ` Paolo Bonzini
2011-06-06 9:18 ` Rainer Orth
2011-06-06 9:23 ` Paolo Bonzini [this message]
2011-06-07 15:20 ` Joseph S. Myers
2011-06-07 15:31 ` Rainer Orth
2011-06-07 15:45 ` Paolo Bonzini
2011-06-07 19:17 ` Joseph S. Myers
2011-06-09 7:50 ` Rainer Orth
2011-06-09 9:57 ` Joseph S. Myers
2011-06-09 12:06 ` Bernd Schmidt
2011-06-04 11:00 ` Gerald Pfeifer
2011-06-04 11:17 ` Andreas Schwab
2011-06-07 14:00 ` Joseph S. Myers
2011-06-07 14:57 ` Rainer Orth
2011-05-31 18:11 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEC9C6A.3050106@gnu.org \
--to=bonzini@gnu.org \
--cc=Ralf.Wildenhues@gmx.de \
--cc=dave.korn.cygwin@gmail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=krister.walfridsson@gmail.com \
--cc=ktietz@redhat.com \
--cc=ljrittle@acm.org \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=rth@redhat.com \
--cc=thorpej@netbsd.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).