From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15801 invoked by alias); 6 Jun 2011 12:41:47 -0000 Received: (qmail 15793 invoked by uid 22791); 6 Jun 2011 12:41:46 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jun 2011 12:41:33 +0000 Received: (qmail 23164 invoked from network); 6 Jun 2011 12:41:32 -0000 Received: from unknown (HELO ?192.168.0.100?) (ams@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Jun 2011 12:41:32 -0000 Message-ID: <4DECCAF8.5030406@codesourcery.com> Date: Mon, 06 Jun 2011 12:41:00 -0000 From: Andrew Stubbs User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Dmitry Plotnikov CC: Ramana Radhakrishnan , gcc-patches@gcc.gnu.org, patches@linaro.org, dm@ispras.ru Subject: Re: [PATCH][ARM] Add support for ADDW and SUBW instructions References: <4DAEFB5C.8020802@codesourcery.com> <4DE751DF.8080906@codesourcery.com> <4DECC4CB.2000500@ispras.ru> In-Reply-To: <4DECC4CB.2000500@ispras.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00396.txt.bz2 On 06/06/11 13:15, Dmitry Plotnikov wrote: > + && (const_ok_for_op (INTVAL (x), outer) > + || const_ok_for_op (~INTVAL (x), outer)))) The second call is redundant. const_ok_for_op should already do that. Andrew