From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19485 invoked by alias); 8 Jun 2011 02:14:22 -0000 Received: (qmail 19465 invoked by uid 22791); 8 Jun 2011 02:14:21 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Jun 2011 02:13:56 +0000 Received: (qmail 1735 invoked from network); 8 Jun 2011 02:13:55 -0000 Received: from unknown (HELO ?192.168.1.5?) (janisjo@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Jun 2011 02:13:55 -0000 Message-ID: <4DEEDAF0.6090100@codesourcery.com> Date: Wed, 08 Jun 2011 02:54:00 -0000 From: Janis Johnson User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: Mike Stump CC: "Joseph S. Myers" , gcc-patches@gcc.gnu.org Subject: Re: [testsuite] skip ARM tests with conflicting options References: <4DEE8FE7.50001@codesourcery.com> <4DEEB332.2070706@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00605.txt.bz2 On 06/07/2011 06:25 PM, Mike Stump wrote: > On Jun 7, 2011, at 4:24 PM, Janis Johnson wrote: >> On 06/07/2011 02:07 PM, Joseph S. Myers wrote: >>> On Tue, 7 Jun 2011, Janis Johnson wrote: >>> >>>> Several tests in gcc.target/arm use dg-options with -mcpu=xxxx, which >>>> causes compiler warnings or errors when the multilib flags include >>>> -march=yyyy. This patch causes those tests to be skipped. It also >>>> prevents gcc.target/arm/20090811-1.c from running with multilibs that >>>> would override -mcpu or -mfloat-abi options specified for the test. >>> >>> I think you should allow compatible -march options - for example, if >>> dg-options has -mcpu=cortex-a8, allow -march=armv7-a but disallow all >>> other -march options. >>> >> Is this one OK? > > Not sure if the arm people want to review this or would rather I review it... > > Let's give the arm folks a couple days to comment, if no objections, Ok. > > A point of warning, eventually, you'll discover that when a compiler defaults to the argument you want to skip, that you'll needs slightly more power to skip them. darwin ran into this with things like -m64, and eventually had to do something like lp64. configure options like --with-cpu=arm9 are the sort that can change the default. Yes, I hope to hear from ARM people. On ARM, the default from --with-cpu= is overridden by -march at compile so it's not a problem for this particular set of tests. As I said originally, this set is the tip of the iceberg and they get more difficult. Janis