From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26232 invoked by alias); 10 Jun 2011 10:23:46 -0000 Received: (qmail 26217 invoked by uid 22791); 10 Jun 2011 10:23:45 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx02.qsc.de (HELO mx02.qsc.de) (213.148.130.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 10:23:30 +0000 Received: from [192.168.178.22] (port-92-204-18-93.dynamic.qsc.de [92.204.18.93]) by mx02.qsc.de (Postfix) with ESMTP id C9B6A1E3E8; Fri, 10 Jun 2011 12:23:28 +0200 (CEST) Message-ID: <4DF1F0A0.6020804@net-b.de> Date: Fri, 10 Jun 2011 11:04:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Daniel Carrera CC: gfortran , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, Fortran] (Coarray) Change declaration of CAF sync functions. References: <4DF1E006.1070504@gmail.com> In-Reply-To: <4DF1E006.1070504@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00821.txt.bz2 On 06/10/2011 11:12 AM, Daniel Carrera wrote: > This is the patch recently discussed in the GFortran list, now ready > for official submission. > [...] > 2011-06-07 Daniel Carrera > > * gfortran.dg/coarray/sync_1.f90: New > Test "SYNC ALL", "SYNC MEMORY" and "SYNC IMAGES". "Test" -> "test for". > + /* SYNC ALL => stat == null_pointer_node > + SYNC ALL(stat=s) => stat has an integer type > + > + If "stat" has the wrong integer type, use a temp variable of > + the right type and later cast the result back into "stat". */ Intending: The last two lines were space instead of tab-space indented. Additionally, I think you editor automatically indents lines, which causes tailing whitespace in (otherwise) empty lines. I remove those (trans-expr.c, mpi.c). > sync_1.f90: > > ! { dg-do run } > ! { dg-shouldfail "error stop" } As the ERROR STOP has been removed, the test no longer fails. Hence, also the "dg-shouldfail" has to be removed. Otherwise, one gets: $ make check-gfortran RUNTESTFLAGS='caf.exp=sync_1.f90' [...] FAIL: gfortran.dg/coarray/sync_1.f90 -fcoarray=single -O2 execution test FAIL: gfortran.dg/coarray/sync_1.f90 -fcoarray=lib -O2 -lcaf_single execution test It is a frequent problem that one forgets to run the new test cases through the testing system, leading to such failures. Or if one did, one forgets to do it again after some "trivial" test-case change. ;-) With those changes, the patch is OK. I have now committed the patch as Rev. 174896. Congratulation to your first GCC patch! Tobias