From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2117 invoked by alias); 10 Jun 2011 11:28:44 -0000 Received: (qmail 2104 invoked by uid 22791); 10 Jun 2011 11:28:43 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-fx0-f47.google.com (HELO mail-fx0-f47.google.com) (209.85.161.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 11:28:29 +0000 Received: by fxm19 with SMTP id 19so1849241fxm.20 for ; Fri, 10 Jun 2011 04:28:28 -0700 (PDT) Received: by 10.223.30.82 with SMTP id t18mr1917876fac.106.1307705308402; Fri, 10 Jun 2011 04:28:28 -0700 (PDT) Received: from [130.235.236.18] (ip236-18.wireless.lu.se [130.235.236.18]) by mx.google.com with ESMTPS id o23sm1026216faa.33.2011.06.10.04.28.27 (version=SSLv3 cipher=OTHER); Fri, 10 Jun 2011 04:28:27 -0700 (PDT) Message-ID: <4DF1FFE3.7070400@gmail.com> Date: Fri, 10 Jun 2011 11:41:00 -0000 From: Daniel Carrera User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: Tobias Burnus CC: gfortran , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, Fortran] (Coarray) Change declaration of CAF sync functions. References: <4DF1E006.1070504@gmail.com> <4DF1F0A0.6020804@net-b.de> In-Reply-To: <4DF1F0A0.6020804@net-b.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00826.txt.bz2 On 06/10/2011 12:23 PM, Tobias Burnus wrote: >> + /* SYNC ALL => stat == null_pointer_node >> + SYNC ALL(stat=s) => stat has an integer type >> + >> + If "stat" has the wrong integer type, use a temp variable of >> + the right type and later cast the result back into "stat". */ > > Intending: The last two lines were space instead of tab-space indented. > Additionally, I think you editor automatically indents lines, which > causes tailing whitespace in (otherwise) empty lines. I remove those > (trans-expr.c, mpi.c). It's partly the editor and partly me. I like empty lines to have the same indentation as the code and it didn't occur to me that other people might not like it. I'll try to be mindful to not have trailing whitespace in empty lines. >> sync_1.f90: >> >> ! { dg-do run } >> ! { dg-shouldfail "error stop" } > > As the ERROR STOP has been removed, the test no longer fails. Hence, > also the "dg-shouldfail" has to be removed. Ooops. > It is a frequent problem that one forgets to run the new test cases > through the testing system, leading to such failures. Or if one did, one > forgets to do it again after some "trivial" test-case change. ;-) I thought that I *couldn't* run this test through the test system because mpi.c is not currently compiled. I thought the only way to run the test for now was to do it manually like I did this week. Well, now I know. Thanks. > With those changes, the patch is OK. I have now committed the patch as > Rev. 174896. > > Congratulation to your first GCC patch! WHOO HOO!!! \o/ -- I'm not overweight, I'm undertall.