From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30800 invoked by alias); 10 Jun 2011 13:53:44 -0000 Received: (qmail 30790 invoked by uid 22791); 10 Jun 2011 13:53:43 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 13:53:25 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5ADrOPC019356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Jun 2011 09:53:24 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5ADrO2L011016; Fri, 10 Jun 2011 09:53:24 -0400 Received: from Mair.local (vpn-10-68.rdu.redhat.com [10.11.10.68]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5ADrNSB028880; Fri, 10 Jun 2011 09:53:23 -0400 Message-ID: <4DF221D3.4020308@redhat.com> Date: Fri, 10 Jun 2011 14:03:00 -0000 From: Vladimir Makarov User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Hans-Peter Nilsson CC: gcc-patches@gcc.gnu.org Subject: Re: FORBIDDEN_INC_DEC_CLASSES in ira-costs.c References: <4DF0EF39.5020409@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00840.txt.bz2 On 11-06-10 8:35 AM, Hans-Peter Nilsson wrote: > On Thu, 9 Jun 2011, Hans-Peter Nilsson wrote: > >> * ira-costs.c: Remove #ifdefs on dead FORBIDDEN_INC_DEC_CLASSES. >> Adjust comments. >> * system.h (FORBIDDEN_INC_DEC_CLASSES): Poison. >> Index: ira-costs.c >> =================================================================== >> --- ira-costs.c (revision 174878) >> +++ ira-costs.c (working copy) > Oops; I spotted a missing comment update. > Please replace these hunks: > >> @@ -1685,9 +1651,6 @@ find_costs_and_classes (FILE *dump_file) >> /* Ignore classes that are too small for this operand or >> invalid for an operand that was auto-incremented. */ >> if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] >> -#ifdef FORBIDDEN_INC_DEC_CLASSES >> - || (inc_dec_p&& forbidden_inc_dec_class[rclass]) >> -#endif >> #ifdef CANNOT_CHANGE_MODE_CLASS >> || invalid_mode_change_p (i, (enum reg_class) rclass) >> #endif >> @@ -1764,9 +1727,6 @@ find_costs_and_classes (FILE *dump_file) >> operand or invalid for an operand that was >> auto-incremented. */ >> if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] >> -#ifdef FORBIDDEN_INC_DEC_CLASSES >> - || (inc_dec_p&& forbidden_inc_dec_class[rclass]) >> -#endif >> #ifdef CANNOT_CHANGE_MODE_CLASS >> || invalid_mode_change_p (i, (enum reg_class) rclass) >> #endif > > with these: > > > @@ -1682,12 +1648,9 @@ find_costs_and_classes (FILE *dump_file) > for (k = 0; k< cost_classes_ptr->num; k++) > { > rclass = cost_classes[k]; > - /* Ignore classes that are too small for this operand or > - invalid for an operand that was auto-incremented. */ > + /* Ignore classes that are too small or invalid for this > + operand. */ > if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] > -#ifdef FORBIDDEN_INC_DEC_CLASSES > - || (inc_dec_p&& forbidden_inc_dec_class[rclass]) > -#endif > #ifdef CANNOT_CHANGE_MODE_CLASS > || invalid_mode_change_p (i, (enum reg_class) rclass) > #endif > @@ -1760,13 +1723,9 @@ find_costs_and_classes (FILE *dump_file) > rclass = cost_classes[k]; > if (! ira_class_subset_p[rclass][regno_aclass[i]]) > continue; > - /* Ignore classes that are too small for this > - operand or invalid for an operand that was > - auto-incremented. */ > + /* Ignore classes that are too small or invalid > + for this operand. */ > if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)] > -#ifdef FORBIDDEN_INC_DEC_CLASSES > - || (inc_dec_p&& forbidden_inc_dec_class[rclass]) > -#endif > #ifdef CANNOT_CHANGE_MODE_CLASS > || invalid_mode_change_p (i, (enum reg_class) rclass) > #endif > > brgds, H-P The patch is ok with these changes. Thanks for the patch.