From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3315 invoked by alias); 13 Jun 2011 18:19:14 -0000 Received: (qmail 3303 invoked by uid 22791); 13 Jun 2011 18:19:14 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mo-p00-ob.rzone.de (HELO mo-p00-ob.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Jun 2011 18:19:00 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT2k715jHQaJercGOZE+TiTS5oCa9h49M9BI= X-RZG-CLASS-ID: mo00 Received: from [192.168.2.100] (dslb-084-058-250-137.pools.arcor-ip.net [84.58.250.137]) by post.strato.de (klopstock mo35) (RZmta 25.18) with ESMTPA id a074a1n5DHIfN3 ; Mon, 13 Jun 2011 20:18:54 +0200 (MEST) Message-ID: <4DF6548C.2030207@gjlay.de> Date: Mon, 13 Jun 2011 18:40:00 -0000 From: Georg-Johann Lay User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) MIME-Version: 1.0 To: Mike Stump CC: gcc-patches@gcc.gnu.org, Kaz Kojima , Jakub Jelinek , Rainer Orth Subject: Re: [testsuite]: Skip tests for targets with int < 32 bits References: <4DF0F48C.2050308@gjlay.de> <691C71AE-DCA3-4061-8904-C6F970618B17@comcast.net> In-Reply-To: <691C71AE-DCA3-4061-8904-C6F970618B17@comcast.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00988.txt.bz2 Mike Stump schrieb: > On Jun 9, 2011, at 9:27 AM, Georg-Johann Lay wrote: > >>This patch fixes testsuite failures because the testcases assume >>sizeof(int) >= 4. >> >> * gcc.c-torture/compile/pr49029.c: Add dg-require-effective-target >> int32plus >> * gcc.c-torture/compile/pr49163.c: Ditto. > > > Well, since no one objected to it, I'll approve it. I was hoping that a specific maintainer would approve or reject it. :-( Who is a "specific maintainer" here? I found you (and Rainer Orth) as "testsuite" maintainers. Or does that just refer to the test harness and not to specific test cases? I CCed Kaz and Jakub because they added respective test cases. Then I observed that /* { dg-require-effective-target int32plus } */ does not work as intended for all test cases. For exammple, I added this line to, e.g. * gcc.c-torture/execute/cmpsi-2.c * gcc.c-torture/execute/pr45262.c in trunk r172757 http://gcc.gnu.org/viewcvs?view=revision&revision=172757 However, these tests are still executed as you can see in gcc-testresults for trunk r174959: http://gcc.gnu.org/ml/gcc-testresults/2011-06/msg01429.html Is this a bug resp. worth a bug report? Johann