From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21024 invoked by alias); 14 Jun 2011 22:46:56 -0000 Received: (qmail 21016 invoked by uid 22791); 14 Jun 2011 22:46:56 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Jun 2011 22:46:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5EMkZsV008643 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 Jun 2011 18:46:35 -0400 Received: from anchor.twiddle.net (vpn-238-5.phx2.redhat.com [10.3.238.5]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5EMkYVh015903; Tue, 14 Jun 2011 18:46:34 -0400 Message-ID: <4DF7E4CA.4010402@redhat.com> Date: Tue, 14 Jun 2011 23:04:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: Georg-Johann Lay CC: Denis Chertykov , gcc-patches@gcc.gnu.org, Anatoly Sokolov , "Eric B. Weddington" Subject: Re: [Patch, AVR]: Fix PR46779 References: <4DF0FAB5.6070704@gjlay.de> <4DF11D20.4030907@gjlay.de> <4DF1ED76.4030507@gjlay.de> <4DF650B7.3030705@gjlay.de> <4DF73490.2080709@gjlay.de> <4DF7D2B5.1090708@gjlay.de> In-Reply-To: <4DF7D2B5.1090708@gjlay.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01122.txt.bz2 On 06/14/2011 02:29 PM, Georg-Johann Lay wrote: > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01029.html It does look like a step in the right direction. > I tested on some handcrafted examples and on the code attached to > PR46278. The generated code looked very good and so I started > regression testing but found at spill fail in > gcc.c-torture/compile/950612-1.c What compiler options? I tried -O{1,2,s,3} and they all passed. > The major work left to be done are fixing spill fails and > implementing appropriate LEGITIMIZE_RELOAD_ADDRESS which are beyond > my skills. L_R_A is a tad tricky, but there are good examples to copy from. But you shouldn't need that to fix spill failures. L_R_A should simply be able to provide slightly better sharing between addresses. Not that I expect that there will be many instances of that, since you'll quickly run out of registers in which to share anything. > BTW, fixing PR48459, Richard ran immediately into a spill failure during newlib build: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48459#c20 FWIW, that spill failure vanishes with your patch. r~